LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html - Issue 449413002: DevTools: DataGrid: turn "element" getter to function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

Issue 449413002: DevTools: DataGrid: turn "element" getter to function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

diff --git a/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html b/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

index fe39652608831b307f60d5214e508a11c356cfe2..01becbcb836db3c139ae9d3be960696ddf0a1abf 100644

--- a/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

+++ b/LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html

@@ -90,7 +90,7 @@ function test()

var instanceNodes = constructorNode.children;

for (var i = 0; i < instanceNodes.length; i++) {

if (instanceNodes[i].snapshotNodeId == nodeId) {

- if (!instanceNodes[i].element.classList.contains("highlighted-row")) {

+ if (!instanceNodes[i].element().classList.contains("highlighted-row")) {

if (constructorsGrid._nodeToHighlightAfterScroll === instanceNodes[i]) {

function afterScroll(nodeToHighlight)

{

« no previous file with comments | « no previous file | LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html » ('j') | no next file with comments »