LayoutTests/inspector/profiler/heap-snapshot-test.js - Issue 449413002: DevTools: DataGrid: turn "element" getter to function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-test.js

Issue 449413002: DevTools: DataGrid: turn "element" getter to function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html ('k') | Source/devtools/front_end/components/CookiesTable.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/profiler/heap-snapshot-test.js

diff --git a/LayoutTests/inspector/profiler/heap-snapshot-test.js b/LayoutTests/inspector/profiler/heap-snapshot-test.js

index 129a1b7eb08579c0e0d504c588ea4bead68c3620..8cc7b1cd25f366dd91d9c70d32f3d61b7ccc498d 100644

--- a/LayoutTests/inspector/profiler/heap-snapshot-test.js

+++ b/LayoutTests/inspector/profiler/heap-snapshot-test.js

@@ -582,7 +582,7 @@ InspectorTest.columnContents = function(column, row)

for (var node = parent.children[0]; node; node = node.traverseNextNode(true, parent, true)) {

if (!node.selectable)

continue;

- var content = node.element.children[columnOrdinal];

+ var content = node.element().children[columnOrdinal];

// Do not inlcude percents

if (content.firstElementChild)

content = content.firstElementChild;