LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html - Issue 449413002: DevTools: DataGrid: turn "element" getter to function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html

Issue 449413002: DevTools: DataGrid: turn "element" getter to function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/profiler/heap-snapshot-summary-search-by-id.html ('k') | LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html

diff --git a/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html b/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html

index 6f03aa8dc361822b83c032203eee1c468116a382..e9825c2242f16bb9c9754783bb9d24a57465573e 100644

--- a/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html

+++ b/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-fields.html

@@ -63,7 +63,7 @@ function test()

{

columns[currentColumn] = newColumnState;

var columnName = columns[currentColumn].identifier;

- var contents = windowRow.children.map(function(obj) { return obj.element.children[currentColumn].textContent; });

+ var contents = windowRow.children.map(function(obj) { return obj.element().children[currentColumn].textContent; });

InspectorTest.assertEquals(instanceCount, contents.length, "column contents");

var sortTypes = { object: "text", distance: "number", count: "number", shallowSize: "size", retainedSize: "size" };

InspectorTest.assertEquals(true, !!sortTypes[columns[currentColumn].identifier], "sort by identifier");