Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1128)

Unified Diff: Source/devtools/front_end/profiler/CanvasReplayStateView.js

Issue 449413002: DevTools: DataGrid: turn "element" getter to function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/profiler/CanvasReplayStateView.js
diff --git a/Source/devtools/front_end/profiler/CanvasReplayStateView.js b/Source/devtools/front_end/profiler/CanvasReplayStateView.js
index dedb14c2b4b960db0a2c9e7f2f9f7502bc3633db..063d7f4cbe64519956f9085ecc165192c19e8bb3 100644
--- a/Source/devtools/front_end/profiler/CanvasReplayStateView.js
+++ b/Source/devtools/front_end/profiler/CanvasReplayStateView.js
@@ -365,7 +365,7 @@ WebInspector.CanvasReplayStateView.prototype = {
parent.appendChild(childNode);
var oldChildrenItem = oldChildren[childNode.name] || {};
var oldChildNode = oldChildrenItem.node;
- if (!oldChildNode || oldChildNode.element.textContent !== childNode.element.textContent)
+ if (!oldChildNode || oldChildNode.element().textContent !== childNode.element().textContent)
nodesToHighlight.push(childNode);
appendResourceStateDescriptors.call(this, descriptor.values, childNode, oldChildrenItem.children);
}
@@ -385,13 +385,13 @@ WebInspector.CanvasReplayStateView.prototype = {
_updateDataGridHighlights: function(nodes)
{
for (var i = 0, n = this._highlightedGridNodes.length; i < n; ++i)
- this._highlightedGridNodes[i].element.classList.remove("canvas-grid-node-highlighted");
+ this._highlightedGridNodes[i].element().classList.remove("canvas-grid-node-highlighted");
this._highlightedGridNodes = nodes;
for (var i = 0, n = this._highlightedGridNodes.length; i < n; ++i) {
var node = this._highlightedGridNodes[i];
- WebInspector.runCSSAnimationOnce(node.element, "canvas-grid-node-highlighted");
+ WebInspector.runCSSAnimationOnce(node.element(), "canvas-grid-node-highlighted");
node.reveal();
}
},
« no previous file with comments | « Source/devtools/front_end/network/NetworkPanel.js ('k') | Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698