Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 448853002: Move StringToLowerASCII to base namespace (Closed)

Created:
6 years, 4 months ago by brettw
Modified:
3 years, 11 months ago
Reviewers:
jonchitchat, sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Move StringToLowerASCII to base namespace TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288085

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -258 lines) Patch
M android_webview/browser/aw_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_connect.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/command_line.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/environment.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/i18n/rtl.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/string_util.h View 2 chunks +11 lines, -11 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/signature_validator_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/signature_validator_win_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/customization_document.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/token_encryptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/component_updater_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/gcm/gcm_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_mac.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/music_manager_private/device_id_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/external_registry_loader_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/local_extension_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/file_select_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/icon_loader_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/in_process_importer_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/install_verification/win/module_verification_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/media_path_filter.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_hash_calculator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper/device_id_fetcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/search/hotword_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_icon_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/content_settings_pattern.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/custom_handlers/protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/importer/firefox_importer_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/util/language_selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/plugins/plugin_uma.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/capabilities.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/server/http_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/cryptohome/system_salt_getter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/login/auth/key.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/print_job_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/browser/wallet/required_action.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_field.cc View 6 chunks +14 lines, -13 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M components/autofill/core/browser/contact_info.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M components/autofill/core/browser/credit_card.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/autofill/core/browser/form_structure.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/personal_data_manager.cc View 3 chunks +9 lines, -8 lines 0 comments Download
M components/autofill/core/common/save_password_progress_logger.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/language_usage_metrics/language_usage_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/nexe_load_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl/renderer/ppb_nacl_private_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/os_crypt/ie7_password_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/plugins/renderer/mobile_youtube_plugin.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/preg_parser_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/query_parser/snippet_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/signin/core/browser/signin_internals_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/media_storage_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/storage_monitor/portable_device_watcher_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/language_detection/language_detection_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/url_matcher/regex_set_matcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_fetch_stores_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/browser_font_resource_trusted.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/child/npapi/npobject_stub.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/plugin_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/plugin_list.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/common/plugin_list_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/public/browser/media_device_id.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/cache_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/browser/shell_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M crypto/symmetric_key_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/csp_validator.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/id_util.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/common/message_bundle.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/common/permissions/socket_permission_entry.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/engine/gservices_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/feature_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/config/gpu_control_list.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/data_url.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/filename_util_internal.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M net/base/filename_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/host_mapping_rules.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/base/mime_util.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/base/sdch_manager.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M net/cert/x509_certificate.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_constants.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/parsed_cookie.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_config_service_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_hosts.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/dns/host_resolver_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_network_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_auth_gssapi_posix.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_auth_handler_factory.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/http/http_auth_sspi_win.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_log_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_response_headers.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_util.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/proxy/proxy_bypass_rules.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/server/http_server.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/server/http_server_request_info.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M net/server/http_server_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/hpack_huffman_aggregator.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_http_utils.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/test/embedded_test_server/http_request.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/spdy_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_throttler_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_handshake_handler.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M pdf/document_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_page.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/file_chooser_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/setup/daemon_controller_delegate_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M sql/statement.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/base/attachment_id_proto.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/public/base/attachment_id_proto_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/base/clipboard/clipboard_util_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/font_fallback_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/gfx/font_list_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/gfx/font_unittest.cc View 4 chunks +10 lines, -5 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/gl/gl_version_info.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/database/database_identifier.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
brettw
6 years, 4 months ago (2014-08-06 21:41:12 UTC) #1
brettw
Committed patchset #2 manually as 288085 (presubmit successful).
6 years, 4 months ago (2014-08-07 16:56:14 UTC) #2
jonchitchat
3 years, 11 months ago (2017-01-14 18:12:08 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698