Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: ui/gfx/font_unittest.cc

Issue 448853002: Move StringToLowerASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/font_list_unittest.cc ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/font_unittest.cc
diff --git a/ui/gfx/font_unittest.cc b/ui/gfx/font_unittest.cc
index da4bdfcc4bd05a82d85d8d2581263d63408f247c..3c043c0622e351adeb500314f472b60b196bd5f6 100644
--- a/ui/gfx/font_unittest.cc
+++ b/ui/gfx/font_unittest.cc
@@ -64,7 +64,8 @@ TEST_F(FontTest, LoadArial) {
EXPECT_EQ(cf.GetStyle(), Font::NORMAL);
EXPECT_EQ(cf.GetFontSize(), 16);
EXPECT_EQ(cf.GetFontName(), "Arial");
- EXPECT_EQ("arial", StringToLowerASCII(cf.GetActualFontNameForTesting()));
+ EXPECT_EQ("arial",
+ base::StringToLowerASCII(cf.GetActualFontNameForTesting()));
FreeIfNecessary(native);
}
@@ -74,7 +75,8 @@ TEST_F(FontTest, LoadArialBold) {
NativeFont native = bold.GetNativeFont();
EXPECT_TRUE(native);
EXPECT_EQ(bold.GetStyle(), Font::BOLD);
- EXPECT_EQ("arial", StringToLowerASCII(cf.GetActualFontNameForTesting()));
+ EXPECT_EQ("arial",
+ base::StringToLowerASCII(cf.GetActualFontNameForTesting()));
FreeIfNecessary(native);
}
@@ -115,13 +117,15 @@ TEST_F(FontTest, AvgWidths) {
// http://crbug.com/347429
TEST_F(FontTest, GetActualFontNameForTesting) {
Font arial("Arial", 16);
- EXPECT_EQ("arial", StringToLowerASCII(arial.GetActualFontNameForTesting()))
+ EXPECT_EQ("arial",
+ base::StringToLowerASCII(arial.GetActualFontNameForTesting()))
<< "********\n"
<< "Your test environment seems to be missing Arial font, which is "
<< "needed for unittests. Check if Arial font is installed.\n"
<< "********";
Font symbol("Symbol", 16);
- EXPECT_EQ("symbol", StringToLowerASCII(symbol.GetActualFontNameForTesting()))
+ EXPECT_EQ("symbol",
+ base::StringToLowerASCII(symbol.GetActualFontNameForTesting()))
<< "********\n"
<< "Your test environment seems to be missing Symbol font, which is "
<< "needed for unittests. Check if Symbol font is installed.\n"
@@ -130,7 +134,8 @@ TEST_F(FontTest, GetActualFontNameForTesting) {
const char* const invalid_font_name = "no_such_font_name";
Font fallback_font(invalid_font_name, 16);
EXPECT_NE(invalid_font_name,
- StringToLowerASCII(fallback_font.GetActualFontNameForTesting()));
+ base::StringToLowerASCII(
+ fallback_font.GetActualFontNameForTesting()));
}
#endif
« no previous file with comments | « ui/gfx/font_list_unittest.cc ('k') | ui/gfx/render_text_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698