chrome/test/chromedriver/capabilities.cc - Issue 448853002: Move StringToLowerASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/capabilities.cc

Issue 448853002: Move StringToLowerASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/chromedriver/capabilities.cc

diff --git a/chrome/test/chromedriver/capabilities.cc b/chrome/test/chromedriver/capabilities.cc

index ad11603a46d540352b47c4b18e2fc64d467dcfbf..474d3dbb88f5fa61e6a38bceb19eaefc7017c543 100644

--- a/chrome/test/chromedriver/capabilities.cc

+++ b/chrome/test/chromedriver/capabilities.cc

@@ -185,7 +185,7 @@ Status ParseProxy(const base::Value& option, Capabilities* capabilities) {

std::string proxy_type;

if (!proxy_dict->GetString("proxyType", &proxy_type))

return Status(kUnknownError, "'proxyType' must be a string");

- proxy_type = StringToLowerASCII(proxy_type);

+ proxy_type = base::StringToLowerASCII(proxy_type);

if (proxy_type == "direct") {

capabilities->switches.SetSwitch("no-proxy-server");

} else if (proxy_type == "system") {