Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Side by Side Diff: net/cookies/parsed_cookie.cc

Issue 448853002: Move StringToLowerASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « net/cookies/cookie_constants.cc ('k') | net/dns/dns_config_service_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Portions of this code based on Mozilla: 5 // Portions of this code based on Mozilla:
6 // (netwerk/cookie/src/nsCookieService.cpp) 6 // (netwerk/cookie/src/nsCookieService.cpp)
7 /* ***** BEGIN LICENSE BLOCK ***** 7 /* ***** BEGIN LICENSE BLOCK *****
8 * Version: MPL 1.1/GPL 2.0/LGPL 2.1 8 * Version: MPL 1.1/GPL 2.0/LGPL 2.1
9 * 9 *
10 * The contents of this file are subject to the Mozilla Public License Version 10 * The contents of this file are subject to the Mozilla Public License Version
(...skipping 373 matching lines...) Expand 10 before | Expand all | Expand 10 after
384 384
385 // OK, now try to parse a value. 385 // OK, now try to parse a value.
386 std::string::const_iterator value_start, value_end; 386 std::string::const_iterator value_start, value_end;
387 ParseValue(&it, end, &value_start, &value_end); 387 ParseValue(&it, end, &value_start, &value_end);
388 388
389 // OK, we're finished with a Token/Value. 389 // OK, we're finished with a Token/Value.
390 pair.second = std::string(value_start, value_end); 390 pair.second = std::string(value_start, value_end);
391 391
392 // From RFC2109: "Attributes (names) (attr) are case-insensitive." 392 // From RFC2109: "Attributes (names) (attr) are case-insensitive."
393 if (pair_num != 0) 393 if (pair_num != 0)
394 StringToLowerASCII(&pair.first); 394 base::StringToLowerASCII(&pair.first);
395 // Ignore Set-Cookie directives contaning control characters. See 395 // Ignore Set-Cookie directives contaning control characters. See
396 // http://crbug.com/238041. 396 // http://crbug.com/238041.
397 if (!IsValidCookieAttributeValue(pair.first) || 397 if (!IsValidCookieAttributeValue(pair.first) ||
398 !IsValidCookieAttributeValue(pair.second)) { 398 !IsValidCookieAttributeValue(pair.second)) {
399 pairs_.clear(); 399 pairs_.clear();
400 break; 400 break;
401 } 401 }
402 402
403 pairs_.push_back(pair); 403 pairs_.push_back(pair);
404 404
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
489 for (size_t i = 0; i < arraysize(indexes); ++i) { 489 for (size_t i = 0; i < arraysize(indexes); ++i) {
490 if (*indexes[i] == index) 490 if (*indexes[i] == index)
491 *indexes[i] = 0; 491 *indexes[i] = 0;
492 else if (*indexes[i] > index) 492 else if (*indexes[i] > index)
493 --*indexes[i]; 493 --*indexes[i];
494 } 494 }
495 pairs_.erase(pairs_.begin() + index); 495 pairs_.erase(pairs_.begin() + index);
496 } 496 }
497 497
498 } // namespace 498 } // namespace
OLDNEW
« no previous file with comments | « net/cookies/cookie_constants.cc ('k') | net/dns/dns_config_service_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698