chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc - Issue 448853002: Move StringToLowerASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

Issue 448853002: Move StringToLowerASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

diff --git a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

index 821fe2edd1c231eac68e4b9bf9d0c36df545ebe1..ae5ad651aabfc555f8fed57aa85fbfbd2f5abb3a 100644

--- a/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

+++ b/chrome/renderer/safe_browsing/phishing_dom_feature_extractor.cc

@@ -323,7 +323,7 @@ void PhishingDOMFeatureExtractor::HandleInput(

// WebFormControlElement::formControlType() for consistency with the

// way the phishing classification model is created.

std::string type = element.getAttribute("type").utf8();

- StringToLowerASCII(&type);

+ base::StringToLowerASCII(&type);

if (type == "password") {

++page_feature_state_->num_pswd_inputs;

} else if (type == "radio") {

« no previous file with comments | « chrome/renderer/plugins/plugin_uma.cc ('k') | chrome/test/chromedriver/capabilities.cc » ('j') | no next file with comments »