chrome/browser/extensions/api/gcm/gcm_api.cc - Issue 448853002: Move StringToLowerASCII to base namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/gcm/gcm_api.cc

Issue 448853002: Move StringToLowerASCII to base namespace (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/gcm/gcm_api.cc

diff --git a/chrome/browser/extensions/api/gcm/gcm_api.cc b/chrome/browser/extensions/api/gcm/gcm_api.cc

index 9f2a9284c2efc7a47f9b3f01996144aa63c3ed03..c8bac687ed2ce8f165973bf59ea9ba2b8d9c7137 100644

--- a/chrome/browser/extensions/api/gcm/gcm_api.cc

+++ b/chrome/browser/extensions/api/gcm/gcm_api.cc

@@ -69,7 +69,7 @@ const char* GcmResultToError(gcm::GCMClient::Result result) {

}

bool IsMessageKeyValid(const std::string& key) {

- std::string lower = StringToLowerASCII(key);

+ std::string lower = base::StringToLowerASCII(key);

return !key.empty() &&

key.compare(0, arraysize(kCollapseKey) - 1, kCollapseKey) != 0 &&

lower.compare(0,