Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 445703005: Revert of Moving coordinate conversion methods from ash/wm to ui/wm. (Closed)

Created:
6 years, 4 months ago by robliao
Modified:
6 years, 4 months ago
CC:
chromium-reviews, sadrul, tfarina, ben+aura_chromium.org, jam, dcheng, darin-cc_chromium.org, kalyank, ben+ash_chromium.org, Ryan Hamilton
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Moving coordinate conversion methods from ash/wm to ui/wm. (https://codereview.chromium.org/425363002/) Reason for revert: Build break. ../../ash/display/mouse_cursor_event_filter_ozone.cc:21:7:error: no member named 'ConvertPointToScreen' in namespace 'ash::wm' wm::ConvertPointToScreen(target, &point_in_screen); ~~~~^ ../../ash/display/mouse_cursor_event_filter_ozone.cc:45:7:error: no member named 'ConvertPointFromScreen' in namespace 'ash::wm' wm::ConvertPointFromScreen(root_at_point, &point_in_root); ~~~~^ ../../ash/display/mouse_cursor_event_filter_ozone.cc:86:7:error: no member named 'ConvertPointFromScreen' in namespace 'ash::wm' wm::ConvertPointFromScreen(dst_root, &point_in_dst_screen); ~~~~^ Original issue's description: > Moving coordinate conversion methods from ash/wm to ui/wm. > > Moving ConvertPointToScreen and ConvertPointFromScreen from ash::wm into > aura::Window. The suggestion to do this was made here: > https://codereview.chromium.org/420603011/diff/1/athena/wm/coordinate_conversion.h > > BUG=NONE > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287609 TBR=oshima@chromium.org,ben@chromium.org,sky@chromium.org,mfomitchev@chromium.org NOTREECHECKS=true NOTRY=true BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=287626

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -120 lines) Patch
M ash/autoclick/autoclick_controller.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/display/event_transformation_handler.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 6 chunks +5 lines, -5 lines 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/shelf/shelf_bezel_event_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_view.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/coordinate_conversion.h View 1 chunk +10 lines, -0 lines 0 comments Download
M ash/wm/coordinate_conversion.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/drag_window_resizer.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/gestures/overview_gesture_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_resizer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 3 chunks +2 lines, -2 lines 0 comments Download
D ui/wm/core/coordinate_conversion.h View 1 chunk +0 lines, -32 lines 0 comments Download
D ui/wm/core/coordinate_conversion.cc View 1 chunk +0 lines, -29 lines 0 comments Download
M ui/wm/wm.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robliao
Created Revert of Moving coordinate conversion methods from ash/wm to ui/wm.
6 years, 4 months ago (2014-08-05 22:44:19 UTC) #1
robliao
6 years, 4 months ago (2014-08-05 22:46:26 UTC) #2
robliao
The CQ bit was checked by robliao@chromium.org
6 years, 4 months ago (2014-08-05 22:46:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robliao@chromium.org/445703005/1
6 years, 4 months ago (2014-08-05 22:46:53 UTC) #4
commit-bot: I haz the power
Change committed as 287626
6 years, 4 months ago (2014-08-05 22:49:35 UTC) #5
mfomitchev
So trybots don't catch ozone compile errors? I have fixed this particular error, but how ...
6 years, 4 months ago (2014-08-05 23:23:42 UTC) #6
robliao
6 years, 4 months ago (2014-08-05 23:38:25 UTC) #7
Message was sent while issue was closed.
On 2014/08/05 23:23:42, mfomitchev wrote:
> So trybots don't catch ozone compile errors?
> I have fixed this particular error, but how can I ensure that there are no
other
> errors like this?
> Thanks!

The CQ might not by default, but maybe these trybots will help:
linux_chromium_chromeos_ozone_dbg and linux_chromium_chromeos_ozone_rel

Powered by Google App Engine
This is Rietveld 408576698