Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Issue 442323002: Remove unused UseCounter features (Closed)

Created:
6 years, 4 months ago by philipj_slow
Modified:
6 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Remove unused UseCounter features These are the reviews in which the enum values became unused: SVGInstanceRoot: https://codereview.chromium.org/272523002 PromiseConstructor/PromiseCast/PromiseReject/PromiseResolve: https://codereview.chromium.org/293933002 TextAutosizingLayout: https://codereview.chromium.org/346603005 PrefixedElementRequestPointerLock/PrefixedDocumentExitPointerLock/PrefixedDocumentPointerLockElement: https://codereview.chromium.org/437443005 PrefixedConvertPointFromPageToNode/PrefixedConvertPointFromNodeToPage: https://codereview.chromium.org/428533003 MixedContentTextTrack: https://codereview.chromium.org/348853009 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M Source/core/frame/UseCounter.h View 7 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
PTAL
6 years, 4 months ago (2014-08-06 13:13:53 UTC) #1
Mike West
lgtm Assuming it compiles, LGTM! Thanks for this cleanup.
6 years, 4 months ago (2014-08-06 13:24:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/442323002/1
6 years, 4 months ago (2014-08-06 13:25:27 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_compile_dbg on tryserver.blink ...
6 years, 4 months ago (2014-08-06 15:54:41 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-06 16:19:58 UTC) #5
Message was sent while issue was closed.
Change committed as 179627

Powered by Google App Engine
This is Rietveld 408576698