Refactor mixed content checks against the top frame into MixedContentChecker.

Refactor mixed content checks against the top frame into MixedContentChecker.

We shouldn't force the callsites to understand that they need to check the
top-level frame. It leads to bugs and oversights, at least one of which is
fixed by this patch.

BUG=390123
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177285

[Mike West, 2014-06-30 10:29:07]

Hey Jochen, WDYT about this refactoring?

-mike

[jochen (gone - plz use gerrit), 2014-06-30 11:54:54]

not sure I understand this. in the ping loader case, where is the check now?

And in the websocket case, why is there still the MixedContentChecker call right
after the check you removed?

[Mike West, 2014-06-30 12:24:37]

https://codereview.chromium.org/348853009/diff/20001/Source/core/loader/PingL...
File Source/core/loader/PingLoader.cpp (right):

https://codereview.chromium.org/348853009/diff/20001/Source/core/loader/PingL...
Source/core/loader/PingLoader.cpp:123: if
(!frame->loader().mixedContentChecker()->canRunInsecureContent(frame->document()->securityOrigin(),
request.url()))
The PingLoader check is here. We were previously doing two checks: one for the
current frame, one for the top frame. Now we're wrapping that up into the
MixedContentChecker.

https://codereview.chromium.org/348853009/diff/20001/Source/modules/websocket...
File Source/modules/websockets/MainThreadWebSocketChannel.cpp (right):

https://codereview.chromium.org/348853009/diff/20001/Source/modules/websocket...
Source/modules/websockets/MainThreadWebSocketChannel.cpp:100: if
(MixedContentChecker::isMixedContent(m_document->securityOrigin(), url)) {
This is here in case the user has flipped the about:flag we're talking about in
the other CL. I'm not at all sure that it's necessary, since we'll still be
throwing the passive-content warning, but it's our current behavior.

[Mike West, 2014-07-01 06:18:57]

Ping.

[jochen (gone - plz use gerrit), 2014-07-01 07:26:11]

lgtm

[Mike West, 2014-07-01 07:47:12]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-07-01 07:48:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkwst@chromium.org/348853009/20001

[commit-bot: I haz the power, 2014-07-01 08:52:51]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)

[commit-bot: I haz the power, 2014-07-01 09:57:10]

Change committed as 177285