Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 346603005: Remove the old text autosizer (Closed)

Created:
6 years, 6 months ago by pdr.
Modified:
6 years, 4 months ago
Reviewers:
skobes, pfeldman
CC:
blink-reviews, blink-reviews-rendering, zoltan1, sof, eae+blinkwatch, leviw+renderwatch, blink-reviews-dom_chromium.org, dglazkov+blink, jchaffraix+rendering, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove the old text autosizer This patch removes the old text autosizer. Long live the fast text autosizer!* *which we should rename to TextAutosizer in a followup patch. BUG=385380 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179181

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix linker bug #

Patch Set 4 : Rebase for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -72 lines) Patch
M Source/core/core.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.h View 1 2 3 3 chunks +0 lines, -5 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 3 chunks +0 lines, -16 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 chunks +2 lines, -26 lines 0 comments Download
M Source/core/page/Page.cpp View 1 2 2 chunks +1 line, -13 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 2 chunks +1 line, -9 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 30 (0 generated)
pdr.
6 years, 6 months ago (2014-06-26 05:09:52 UTC) #1
skobes
I think we should do this after it hits stable channel.
6 years, 6 months ago (2014-06-26 11:42:34 UTC) #2
pdr.
On 2014/06/26 11:42:34, skobes wrote: > I think we should do this after it hits ...
6 years, 6 months ago (2014-06-26 17:49:40 UTC) #3
skobes
On 2014/06/26 17:49:40, pdr wrote: > This is now just dead code that keeps breaking. ...
6 years, 6 months ago (2014-06-26 18:06:51 UTC) #4
skobes
lgtm FTA hit stable channel yesterday (yay!) Let's submit this now.
6 years, 5 months ago (2014-07-22 23:04:39 UTC) #5
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-07-23 05:16:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/346603005/1
6 years, 5 months ago (2014-07-23 05:17:09 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-23 05:17:18 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Source/core/core.gypi: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-23 05:17:19 UTC) #9
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-07-24 18:33:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/346603005/20001
6 years, 5 months ago (2014-07-24 18:34:20 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-24 20:33:46 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 20:36:35 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/11028)
6 years, 5 months ago (2014-07-24 20:36:36 UTC) #14
pdr.
On 2014/07/24 20:36:36, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-25 07:18:48 UTC) #15
pfeldman
lgtm
6 years, 5 months ago (2014-07-25 07:20:02 UTC) #16
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 5 months ago (2014-07-25 07:21:35 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/346603005/20001
6 years, 5 months ago (2014-07-25 07:22:35 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_blink_compile_dbg on tryserver.blink ...
6 years, 5 months ago (2014-07-25 08:45:14 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 08:55:50 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/17659) mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/17085)
6 years, 5 months ago (2014-07-25 08:55:51 UTC) #21
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 4 months ago (2014-07-29 20:30:00 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/346603005/40001
6 years, 4 months ago (2014-07-29 20:31:07 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-29 20:31:17 UTC) #24
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Document.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 4 months ago (2014-07-29 20:31:18 UTC) #25
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 4 months ago (2014-07-29 20:51:47 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/346603005/50008
6 years, 4 months ago (2014-07-29 20:52:17 UTC) #27
commit-bot: I haz the power
Change committed as 179181
6 years, 4 months ago (2014-07-29 22:24:56 UTC) #28
Peter Beverloo
On 2014/07/29 22:24:56, I haz the power (commit-bot) wrote: > Change committed as 179181 TextAutosizer.(cpp|h) ...
6 years, 4 months ago (2014-07-30 01:17:24 UTC) #29
pdr.
6 years, 4 months ago (2014-07-30 01:19:30 UTC) #30
Message was sent while issue was closed.
On 2014/07/30 01:17:24, Peter Beverloo wrote:
> On 2014/07/29 22:24:56, I haz the power (commit-bot) wrote:
> > Change committed as 179181
> 
> TextAutosizer.(cpp|h) somehow went missing in your later patch sets, and
didn't
> get removed. Surely you meant to remove those? :-)

Good catch :)

I have a followup in the queue: https://codereview.chromium.org/427953003.

Powered by Google App Engine
This is Rietveld 408576698