Remove the old text autosizer

Remove the old text autosizer

This patch removes the old text autosizer. Long live the fast text
autosizer!*


*which we should rename to TextAutosizer in a followup patch.

BUG=385380
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179181

[skobes, 2014-06-26 11:42:34]

I think we should do this after it hits stable channel.

[pdr., 2014-06-26 17:49:40]

On 2014/06/26 11:42:34, skobes wrote:
> I think we should do this after it hits stable channel.

This is now just dead code that keeps breaking. We're past the point of no
return now :) If we want it back, we can just revert this change.

[skobes, 2014-06-26 18:06:51]

On 2014/06/26 17:49:40, pdr wrote:
> This is now just dead code that keeps breaking. We're past the point of no
> return now :) If we want it back, we can just revert this change.

It's not really dead if the majority of users are running it. :)  Even if we're
not going to flip the switch back, it's useful to have in testing, for example
to determine whether a bug report is a regression.

Is this blocking anything?  What's the rush?

[skobes, 2014-07-22 23:04:39]

lgtm

FTA hit stable channel yesterday (yay!)  Let's submit this now.

[pdr., 2014-07-23 05:16:28]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-07-23 05:17:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pdr@chromium.org/346603005/1

[commit-bot: I haz the power, 2014-07-23 05:17:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 05:17:19]

Failed to apply patch for Source/core/core.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/core.gypi
  Hunk #1 FAILED at 1669.
  1 out of 1 hunk FAILED -- saving rejects to file Source/core/core.gypi.rej

Patch:       Source/core/core.gypi
Index: Source/core/core.gypi
diff --git a/Source/core/core.gypi b/Source/core/core.gypi
index
817affc248c6b92ba09e399fd7f0d142eff310f8..87ead3a346b2efd9e92581fd4925ef5ba98143bb
100644
--- a/Source/core/core.gypi
+++ b/Source/core/core.gypi
@@ -1669,8 +1669,6 @@
             'rendering/SubtreeLayoutScope.cpp',
             'rendering/SubtreeLayoutScope.h',
             'rendering/TableLayout.h',
-            'rendering/TextAutosizer.cpp',
-            'rendering/TextAutosizer.h',
             'rendering/TrailingFloatsRootInlineBox.h',
             'rendering/VerticalPositionCache.h',
             'rendering/break_lines.cpp',

[pdr., 2014-07-24 18:33:46]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-07-24 18:34:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pdr@chromium.org/346603005/20001

[commit-bot: I haz the power, 2014-07-24 20:33:46]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/16974)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18797)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/32877)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/37899)

[commit-bot: I haz the power, 2014-07-24 20:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-24 20:36:36]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[pdr., 2014-07-25 07:18:48]

On 2014/07/24 20:36:36, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   blink_presubmit on tryserver.blink
>
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

+cc pfeldman for Source/web LGTM

[pfeldman, 2014-07-25 07:20:02]

lgtm

[pdr., 2014-07-25 07:21:35]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-07-25 07:22:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pdr@chromium.org/346603005/20001

[commit-bot: I haz the power, 2014-07-25 08:45:14]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_db...)
  android_blink_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_blink_compile_re...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/17069)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/18905)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/33216)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/38253)

[commit-bot: I haz the power, 2014-07-25 08:55:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-25 08:55:51]

Try jobs failed on following builders:
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/17085)

[pdr., 2014-07-29 20:30:00]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-07-29 20:31:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pdr@chromium.org/346603005/40001

[commit-bot: I haz the power, 2014-07-29 20:31:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-29 20:31:18]

Failed to apply patch for Source/core/dom/Document.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Document.h
  Hunk #2 succeeded at 959 (offset -2 lines).
  Hunk #3 FAILED at 1353.
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/dom/Document.h.rej

Patch:       Source/core/dom/Document.h
Index: Source/core/dom/Document.h
diff --git a/Source/core/dom/Document.h b/Source/core/dom/Document.h
index
412cc3af9934731bd65ad6b62bd5ecbe04d44e67..261c33919a16d160f7e106972c36c48af1544808
100644
--- a/Source/core/dom/Document.h
+++ b/Source/core/dom/Document.h
@@ -143,7 +143,6 @@ class StyleResolver;
 class StyleSheet;
 class StyleSheetList;
 class Text;
-class TextAutosizer;
 class Touch;
 class TouchList;
 class TransformSource;
@@ -962,9 +961,6 @@ public:
 
     IntSize initialViewportSize() const;
 
-    // There are currently two parallel autosizing implementations:
TextAutosizer and FastTextAutosizer.
-    // See http://tinyurl.com/chromium-fast-autosizer for more details.
-    TextAutosizer* textAutosizer();
     FastTextAutosizer* fastTextAutosizer();
 
     PassRefPtrWillBeRawPtr<Element> createElement(const AtomicString&
localName, const AtomicString& typeExtension, ExceptionState&);
@@ -1357,7 +1353,6 @@ private:
 
     RefPtrWillBeMember<ScriptedAnimationController>
m_scriptedAnimationController;
     OwnPtr<MainThreadTaskRunner> m_taskRunner;
-    OwnPtr<TextAutosizer> m_textAutosizer;
     OwnPtr<FastTextAutosizer> m_fastTextAutosizer;
 
     RefPtrWillBeMember<CustomElementRegistrationContext> m_registrationContext;

[pdr., 2014-07-29 20:51:47]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-07-29 20:52:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pdr@chromium.org/346603005/50008

[commit-bot: I haz the power, 2014-07-29 22:24:56]

Change committed as 179181

[Peter Beverloo, 2014-07-30 01:17:24]

On 2014/07/29 22:24:56, I haz the power (commit-bot) wrote:
> Change committed as 179181

TextAutosizer.(cpp|h) somehow went missing in your later patch sets, and didn't
get removed. Surely you meant to remove those? :-)

[pdr., 2014-07-30 01:19:30]

On 2014/07/30 01:17:24, Peter Beverloo wrote:
> On 2014/07/29 22:24:56, I haz the power (commit-bot) wrote:
> > Change committed as 179181
> 
> TextAutosizer.(cpp|h) somehow went missing in your later patch sets, and
didn't
> get removed. Surely you meant to remove those? :-)

Good catch :)

I have a followup in the queue: https://codereview.chromium.org/427953003.