Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 437443005: Revert of Revert of Remove prefixed Pointer Lock API. (Closed)

Created:
6 years, 4 months ago by scheib
Modified:
6 years, 4 months ago
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Remove prefixed Pointer Lock API. (https://codereview.chromium.org/424213007/) Reason for revert: Downstream tests have been updated to use unprefixed pointer lock in https://codereview.chromium.org/438693003/ Original issue's description: > Revert of Remove prefixed Pointer Lock API. (https://codereview.chromium.org/424093006/) > > Reason for revert: > The change broke several Chromium OS interactive_ui_tests: > > ExtensionPointerLockAccessFail > ExtensionPointerLockAccessPass > EscapingMouseLock > MouseLockSilentAfterTargetUnlock > TestTabDoesntExitMouseLockOnSubFrameNavigation > TestTabExitsMouseLockOnGoBack > TestTabExitsMouseLockOnNavigation > PointerLock_PointerLockLostWithFocus > > that were using the prefixed API (""Uncaught TypeError: undefined is not a function"). > > See > http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/735/steps/interactive_ui_tests/logs/stdio > > Original issue's description: > > Remove prefixed Pointer Lock API. > > > > The Pointer Lock API http://www.w3.org/TR/pointerlock has already been > > implemented without prefix, this change removes the 'webkit' prefixed > > API endpoints. > > > > Intent to Deprecate and Remove: > > https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/tN8fWRtG0MI > > > > BUG=398457 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179172 > > TBR=abarth@chromium.org,scheib@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=398457 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179186 TBR=abarth@chromium.org,jchaffraix@chromium.org NOTREECHECKS=true NOTRY=true BUG=398457 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1304 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-prefixed.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/iframe-sandboxed-allow-pointer-lock-prefixed-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-prefixed.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-allow-pointer-lock-prefixed-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-prefixed.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/iframe-sandboxed-nested-disallow-then-allow-pointer-lock-prefixed-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/iframe-sandboxed-prefixed.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/iframe-sandboxed-prefixed-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/pointerlockelement-different-origin-prefixed.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/pointerlockelement-different-origin-prefixed-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/pointerlockelement-same-origin-prefixed.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/pointerlockelement-same-origin-prefixed-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-prefixed.html View 1 chunk +0 lines, -50 lines 0 comments Download
D LayoutTests/http/tests/pointer-lock/requestPointerLock-can-not-transfer-between-documents-prefixed-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/http/tests/resources/pointer-lock/iframe-allows-inner-iframe-prefixed.html View 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/http/tests/resources/pointer-lock/iframe-common-prefixed.js View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/http/tests/resources/pointer-lock/inner-iframe-prefixed.html View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/http/tests/resources/pointer-lock/pointer-lock-test-harness-prefixed.js View 1 chunk +0 lines, -88 lines 0 comments Download
D LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-prefixed.html View 1 chunk +0 lines, -53 lines 0 comments Download
D LayoutTests/pointer-lock/bug90391-move-then-window-open-crash-prefixed-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/pointer-lock/lock-already-locked-prefixed.html View 1 chunk +0 lines, -63 lines 0 comments Download
D LayoutTests/pointer-lock/lock-already-locked-prefixed-expected.txt View 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/pointer-lock/lock-element-not-in-dom-prefixed.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/pointer-lock/lock-element-not-in-dom-prefixed-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/pointer-lock/locked-element-iframe-removed-from-dom-prefixed.html View 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/pointer-lock/locked-element-iframe-removed-from-dom-prefixed-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/pointer-lock/locked-element-removed-from-dom-prefixed.html View 1 chunk +0 lines, -52 lines 0 comments Download
D LayoutTests/pointer-lock/locked-element-removed-from-dom-prefixed-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/pointer-lock/mouse-event-api-prefixed.html View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/pointer-lock/mouse-event-api-prefixed-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/pointer-lock/mouse-event-delivery-prefixed.html View 1 chunk +0 lines, -102 lines 0 comments Download
D LayoutTests/pointer-lock/mouse-event-delivery-prefixed-expected.txt View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/pointer-lock/pointer-lock-api-prefixed.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/pointer-lock/pointer-lock-api-prefixed-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/pointer-lock/pointerlockchange-event-on-lock-lost-prefixed.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/pointer-lock/pointerlockchange-event-on-lock-lost-prefixed-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-prefixed.html View 1 chunk +0 lines, -117 lines 0 comments Download
D LayoutTests/pointer-lock/pointerlockchange-pointerlockerror-events-prefixed-expected.txt View 1 chunk +0 lines, -43 lines 0 comments Download
D LayoutTests/pointer-lock/pointerlockelement-null-when-pending-prefixed.html View 1 chunk +0 lines, -45 lines 0 comments Download
D LayoutTests/pointer-lock/pointerlockelement-null-when-pending-prefixed-expected.txt View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/core/dom/Document.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/dom/Document.idl View 2 chunks +0 lines, -4 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/events/EventTypeNames.in View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/page/PointerLockController.cpp View 3 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheib
Created Revert of Revert of Remove prefixed Pointer Lock API.
6 years, 4 months ago (2014-08-01 20:23:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scheib@chromium.org/437443005/1
6 years, 4 months ago (2014-08-01 20:23:47 UTC) #2
commit-bot: I haz the power
Change committed as 179419
6 years, 4 months ago (2014-08-01 20:24:31 UTC) #3
philipj_slow
Can you remove the related use counters as well?
6 years, 4 months ago (2014-08-05 05:24:27 UTC) #4
scheib
6 years, 4 months ago (2014-08-05 16:49:32 UTC) #5
Which? The prefixed use counters have been removed unless I made a mistake.
The unprefixed counters should be useful still to understand feature usage.


On Mon, Aug 4, 2014 at 10:24 PM, <philipj@opera.com> wrote:

> Can you remove the related use counters as well?
>
> https://codereview.chromium.org/437443005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698