Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 293933002: Remove the Promises old implementation. (Closed)

Created:
6 years, 7 months ago by yhirano
Modified:
6 years, 7 months ago
CC:
blink-reviews, jsbell+serviceworker_chromium.org, serviceworker-reviews, arv+blink, tzik, sof, eae+blinkwatch, nhiroki, abarth-chromium, kinuko, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, falken, horo+watch_chromium.org, watchdog-blink-watchlist_google.com, alecflett+watch_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove the Promises old implementation. As V8 Promises are enabled, the old Promises implementation can be deleted. This CL also adds some unittests for ScriptPromise and ScriptPromiseResolver. BUG=352552, 352597 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174632

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -1183 lines) Patch
M Source/bindings/bindings.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/v8/ScriptPromise.cpp View 1 4 chunks +2 lines, -9 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseResolver.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseResolver.cpp View 6 chunks +2 lines, -19 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseResolverTest.cpp View 2 chunks +91 lines, -72 lines 0 comments Download
M Source/bindings/v8/ScriptPromiseTest.cpp View 4 chunks +150 lines, -21 lines 0 comments Download
M Source/bindings/v8/V8Initializer.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
D Source/bindings/v8/custom/V8PromiseCustom.h View 1 1 chunk +0 lines, -132 lines 0 comments Download
D Source/bindings/v8/custom/V8PromiseCustom.cpp View 1 1 chunk +0 lines, -827 lines 0 comments Download
M Source/core/core.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
D Source/core/dom/Promise.h View 1 chunk +0 lines, -46 lines 0 comments Download
D Source/core/dom/Promise.idl View 1 chunk +0 lines, -46 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
yhirano
6 years, 7 months ago (2014-05-22 05:07:21 UTC) #1
jochen (gone - plz use gerrit)
lgtm++
6 years, 7 months ago (2014-05-22 08:25:02 UTC) #2
haraken
LGTM2, it's great V8PromiseCustom is gone (I was just trying to refactor it) :)
6 years, 7 months ago (2014-05-22 08:26:59 UTC) #3
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 7 months ago (2014-05-22 08:35:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/293933002/20001
6 years, 7 months ago (2014-05-22 08:35:29 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 14:36:24 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 14:37:26 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9765)
6 years, 7 months ago (2014-05-22 14:37:27 UTC) #8
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 7 months ago (2014-05-22 14:37:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/293933002/20001
6 years, 7 months ago (2014-05-22 14:38:27 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-22 16:31:15 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-22 16:32:24 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/9765)
6 years, 7 months ago (2014-05-22 16:32:25 UTC) #13
yhirano
The CQ bit was checked by yhirano@chromium.org
6 years, 7 months ago (2014-05-23 01:53:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yhirano@chromium.org/293933002/20001
6 years, 7 months ago (2014-05-23 01:54:24 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 01:55:13 UTC) #16
Message was sent while issue was closed.
Change committed as 174632

Powered by Google App Engine
This is Rietveld 408576698