Issue 428533003: Remove webkitConvertPointFromPageToNode() and webkitConvertPointFromNodeToPage()

Issue 428533003: Remove webkitConvertPointFromPageToNode() and webkitConvertPointFromNodeToPage() (Closed)

Created:
6 years, 4 months ago by philipj_slow

Modified:
6 years, 4 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Remove webkitConvertPointFromPageToNode() and webkitConvertPointFromNodeToPage() Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/KS5GAM7JXtg/7KyhsqQFZMkJ BUG=398352 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179135

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -933 lines)			Patch
D	LayoutTests/fast/dom/Window/webkitConvertPoint.html	View	1 chunk	+0 lines, -187 lines	0 comments	Download
D	LayoutTests/fast/dom/Window/webkitConvertPoint-expected.txt	View	1 chunk	+0 lines, -200 lines	0 comments	Download
D	LayoutTests/fast/dom/Window/webkitConvertPointUpdateLayout.html	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	LayoutTests/fast/dom/Window/webkitConvertPointUpdateLayout-expected.txt	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	LayoutTests/fast/transforms/matrix-with-zoom.html	View	1 chunk	+4 lines, -4 lines	0 comments	Download
D	LayoutTests/platform/linux/fast/dom/Window/webkitConvertPoint-expected.txt	View	1 chunk	+0 lines, -200 lines	0 comments	Download
D	LayoutTests/platform/win-xp/fast/dom/Window/webkitConvertPoint-expected.txt	View	1 chunk	+0 lines, -200 lines	0 comments	Download
M	LayoutTests/transforms/2d/cssmatrix-2d-zoom.html	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/transforms/2d/set-transform-and-top.html	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/transforms/3d/general/cssmatrix-3d-zoom.html	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/transforms/3d/general/matrix-with-zoom-3d.html	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/Node.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	Source/core/dom/Node.cpp	View	1 chunk	+0 lines, -28 lines	0 comments	Download
M	Source/core/frame/LocalDOMWindow.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/core/frame/LocalDOMWindow.cpp	View	2 chunks	+0 lines, -31 lines	0 comments	Download
M	Source/core/frame/Window.idl	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/428533003/1

6 years, 4 months ago (2014-07-29 11:46:27 UTC) #4

philipj_slow

6 years, 3 months ago (2014-08-29 09:30:16 UTC) #6

Message was sent while issue was closed.

A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/524523003/ by philipj@opera.com.

The reason for reverting is: Wait for WebKitPoint use counter data and remove
them together:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/KS5GAM7JXtg/AXNh8otM....

Expand Messages | Collapse Messages