Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed)

Created:
6 years, 5 months ago by kozyatinskiy1
Modified:
6 years, 4 months ago
Reviewers:
vsevik, sof, pfeldman
CC:
blink-reviews, tzik, eae+blinkwatch, fs, eric.carlson_apple.com, apavlov+blink_chromium.org, kinuko+worker_chromium.org, aandrey+blink_chromium.org, rwlbuis, jsbell+serviceworker_chromium.org, Yoav Weiss, krit, arv+blink, blink-reviews-css, blink-reviews-html_chromium.org, abarth-chromium, nhiroki, blink-reviews-dom_chromium.org, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, kinuko+serviceworker, pdr., rune+blink, kenneth.christiansen, nessy, zoltan1, alecflett+watch_chromium.org, sof, kouhei+svg_chromium.org, gyuyoung.kim_webkit.org, darktears, Nate Chapin, vcarbune.chromium, philipj_slow, michaeln, blink-reviews-rendering, serviceworker-reviews, gasubic, leviw+renderwatch, falken, blink-reviews-events_chromium.org, ed+blinkwatch_opera.com, f(malita), horo+watch_chromium.org, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args
Project:
blink
Visibility:
Public.

Description

DevTools: wrapping arguments addConsoleMessage in ConsoleMessage Wrapped arguments in remaining addConsoleMessage and addMessage methods in ConsoleMessage class. R=vsevik@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179934

Patch Set 1 #

Patch Set 2 : #

Total comments: 14

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -134 lines) Patch
M Source/bindings/core/v8/ScriptController.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/MediaList.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/AddConsoleMessageTask.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/dom/Document.h View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 3 4 8 chunks +18 lines, -37 lines 0 comments Download
M Source/core/dom/ExecutionContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/ExecutionContext.cpp View 1 chunk +2 lines, -9 lines 0 comments Download
M Source/core/dom/ExecutionContextClient.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ScriptLoader.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/frame/csp/CSPDirectiveList.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/csp/CSPDirectiveList.cpp View 1 2 3 2 chunks +8 lines, -5 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/html/HTMLIFrameElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/HTMLMetaElement-in.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/HTMLShadowElement.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/html/parser/XSSAuditorDelegate.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 2 3 4 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 2 4 chunks +13 lines, -6 lines 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/loader/TextTrackLoader.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/CreateWindow.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/DOMSelection.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/page/EventSource.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/core/page/PointerLockController.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/shapes/ShapeOutsideInfo.cpp View 1 2 3 4 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/svg/SVGDocumentExtensions.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/workers/SharedWorkerGlobalScope.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/workers/WorkerConsole.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/workers/WorkerGlobalScope.h View 1 3 chunks +3 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 2 3 4 1 chunk +6 lines, -8 lines 0 comments Download
M Source/core/workers/WorkerMessagingProxy.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/workers/WorkerObjectProxy.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/workers/WorkerObjectProxy.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/workers/WorkerReportingProxy.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/xml/XMLHttpRequest.cpp View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 2 3 4 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseBackendBase.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseManager.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/websockets/DOMWebSocket.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/websockets/MainThreadWebSocketChannel.cpp View 1 2 5 chunks +5 lines, -4 lines 0 comments Download
M Source/modules/websockets/NewWebSocketChannelImpl.cpp View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/web/WebSharedWorkerImpl.h View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M Source/web/WebSharedWorkerImpl.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 18 (0 generated)
kozyatinskiy1
@vsevik, please take a look!
6 years, 5 months ago (2014-07-25 10:07:21 UTC) #1
kozyatinskiy1
On 2014/07/25 10:07:21, kozyatinskiy wrote: > @vsevik, please take a look! All Document methods add*Message(ConsoleMessage) ...
6 years, 4 months ago (2014-08-04 14:47:19 UTC) #2
vsevik
lgtm with some nits. https://chromiumcodereview.appspot.com/419203004/diff/20001/Source/core/frame/csp/CSPDirectiveList.cpp File Source/core/frame/csp/CSPDirectiveList.cpp (right): https://chromiumcodereview.appspot.com/419203004/diff/20001/Source/core/frame/csp/CSPDirectiveList.cpp#newcode60 Source/core/frame/csp/CSPDirectiveList.cpp:60: void CSPDirectiveList::reportViolationWithState(const String& directiveText, const ...
6 years, 4 months ago (2014-08-08 13:06:29 UTC) #3
kozyatinskiy1
https://codereview.chromium.org/419203004/diff/20001/Source/core/frame/csp/CSPDirectiveList.cpp File Source/core/frame/csp/CSPDirectiveList.cpp (right): https://codereview.chromium.org/419203004/diff/20001/Source/core/frame/csp/CSPDirectiveList.cpp#newcode60 Source/core/frame/csp/CSPDirectiveList.cpp:60: void CSPDirectiveList::reportViolationWithState(const String& directiveText, const String& effectiveDirective, const String& ...
6 years, 4 months ago (2014-08-08 14:58:09 UTC) #4
kozyatinskiy1
https://codereview.chromium.org/419203004/diff/20001/Source/core/workers/WorkerReportingProxy.h File Source/core/workers/WorkerReportingProxy.h (right): https://codereview.chromium.org/419203004/diff/20001/Source/core/workers/WorkerReportingProxy.h#newcode35 Source/core/workers/WorkerReportingProxy.h:35: #include "core/inspector/ConsoleMessage.h" On 2014/08/08 13:06:29, vsevik wrote: > ditto ...
6 years, 4 months ago (2014-08-08 14:58:54 UTC) #5
vsevik
lgtm https://codereview.chromium.org/419203004/diff/40001/Source/core/dom/Document.h File Source/core/dom/Document.h (right): https://codereview.chromium.org/419203004/diff/40001/Source/core/dom/Document.h#newcode49 Source/core/dom/Document.h:49: #include "core/inspector/ConsoleMessage.h" Forward declaration here?
6 years, 4 months ago (2014-08-08 17:04:00 UTC) #6
kozyatinskiy1
https://codereview.chromium.org/419203004/diff/40001/Source/core/dom/Document.h File Source/core/dom/Document.h (right): https://codereview.chromium.org/419203004/diff/40001/Source/core/dom/Document.h#newcode49 Source/core/dom/Document.h:49: #include "core/inspector/ConsoleMessage.h" On 2014/08/08 17:04:00, vsevik wrote: > Forward ...
6 years, 4 months ago (2014-08-08 17:17:00 UTC) #7
kozyatinskiy1
The CQ bit was checked by kozyatinskiy@google.com
6 years, 4 months ago (2014-08-08 18:28:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/419203004/60001
6 years, 4 months ago (2014-08-08 18:30:05 UTC) #9
kozyatinskiy1
@pfeldman, please take a look. I need owner review to next files: Source/bindings/core/v8/ScriptController.cpp Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp Source/modules/webdatabase/DatabaseBackendBase.cpp ...
6 years, 4 months ago (2014-08-08 19:27:11 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-08-08 20:54:08 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-08 20:57:19 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/12311)
6 years, 4 months ago (2014-08-08 20:57:22 UTC) #13
pfeldman
rslgtm
6 years, 4 months ago (2014-08-11 09:49:58 UTC) #14
kozyatinskiy1
The CQ bit was checked by kozyatinskiy@google.com
6 years, 4 months ago (2014-08-11 09:50:39 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kozyatinskiy@google.com/419203004/80001
6 years, 4 months ago (2014-08-11 09:50:55 UTC) #16
commit-bot: I haz the power
Change committed as 179934
6 years, 4 months ago (2014-08-11 10:59:47 UTC) #17
sof
6 years, 4 months ago (2014-08-11 11:05:45 UTC) #18
Message was sent while issue was closed. 
If you think your CL involves the use of objects that have been
converted/transitioned to Oilpan, feel free to Cc: oilpan-reviews@chromium.org
if you're unsure of Oilpan details. More than happy to help.

Powered by Google App Engine
This is Rietveld 408576698