Source/web/WebSharedWorkerImpl.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebSharedWorkerImpl.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebSharedWorkerImpl.cpp

diff --git a/Source/web/WebSharedWorkerImpl.cpp b/Source/web/WebSharedWorkerImpl.cpp

index 1d7d6881361626e888c845e4315715faa8fb596a..28a63eb0d40e75ce045289d86553fce7f5978753 100644

--- a/Source/web/WebSharedWorkerImpl.cpp

+++ b/Source/web/WebSharedWorkerImpl.cpp

@@ -35,6 +35,7 @@

#include "core/dom/Document.h"

#include "core/events/MessageEvent.h"

#include "core/html/HTMLFormElement.h"

+#include "core/inspector/ConsoleMessage.h"

#include "core/inspector/InspectorInstrumentation.h"

#include "core/inspector/WorkerDebuggerAgent.h"

#include "core/inspector/WorkerInspectorController.h"

@@ -239,7 +240,7 @@ void WebSharedWorkerImpl::reportException(const String& errorMessage, int lineNu

// Not suppported in SharedWorker.

}

-void WebSharedWorkerImpl::reportConsoleMessage(MessageSource source, MessageLevel level, const String& message, int lineNumber, const String& sourceURL)

+void WebSharedWorkerImpl::reportConsoleMessage(PassRefPtr<blink::ConsoleMessage>)

{

// Not supported in SharedWorker.

}

« no previous file with comments | « Source/web/WebSharedWorkerImpl.h ('k') | no next file » | no next file with comments »