Source/core/workers/WorkerReportingProxy.h - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/WorkerReportingProxy.h

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/workers/WorkerReportingProxy.h

diff --git a/Source/core/workers/WorkerReportingProxy.h b/Source/core/workers/WorkerReportingProxy.h

index 9494539909f959c3500f6c63c5358c032f689541..6bd3f01efa1c72e1789b2d5883d185a5543631ae 100644

--- a/Source/core/workers/WorkerReportingProxy.h

+++ b/Source/core/workers/WorkerReportingProxy.h

@@ -36,6 +36,7 @@

namespace blink {

+class ConsoleMessage;

class WorkerGlobalScope;

// APIs used by workers to report console activity.

@@ -44,7 +45,7 @@ public:

virtual ~WorkerReportingProxy() { }

virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL) = 0;

- virtual void reportConsoleMessage(MessageSource, MessageLevel, const String& message, int lineNumber, const String& sourceURL) = 0;

+ virtual void reportConsoleMessage(PassRefPtr<ConsoleMessage>) = 0;

virtual void postMessageToPageInspector(const String&) = 0;

virtual void updateInspectorStateCookie(const String&) = 0;

« no previous file with comments | « Source/core/workers/WorkerObjectProxy.cpp ('k') | Source/core/xml/XMLHttpRequest.cpp » ('j') | no next file with comments »