Source/core/css/MediaList.cpp - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaList.cpp

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/MediaList.cpp

diff --git a/Source/core/css/MediaList.cpp b/Source/core/css/MediaList.cpp

index cd5aab16d3fcd98b5ebfcebd014489d9449b4f75..a231029380efe674323cca2892300d237b4ce513 100644

--- a/Source/core/css/MediaList.cpp

+++ b/Source/core/css/MediaList.cpp

@@ -29,6 +29,7 @@

#include "core/css/parser/MediaQueryParser.h"

#include "core/dom/Document.h"

#include "core/frame/LocalDOMWindow.h"

+#include "core/inspector/ConsoleMessage.h"

#include "wtf/text/StringBuilder.h"

namespace blink {

@@ -275,7 +276,7 @@ static void addResolutionWarningMessageToConsole(Document* document, const Strin

message.append(serializedExpression);

- document->addConsoleMessage(CSSMessageSource, DebugMessageLevel, message.toString());

+ document->addConsoleMessage(ConsoleMessage::create(CSSMessageSource, DebugMessageLevel, message.toString()));

}

static inline bool isResolutionMediaFeature(const String& mediaFeature)

« no previous file with comments | « Source/bindings/core/v8/ScriptController.cpp ('k') | Source/core/dom/AddConsoleMessageTask.cpp » ('j') | no next file with comments »