Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2027)

Side by Side Diff: Source/core/dom/Document.h

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/AddConsoleMessageTask.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All r ights reserved.
7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 7 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies) 8 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
9 * Copyright (C) 2011 Google Inc. All rights reserved. 9 * Copyright (C) 2011 Google Inc. All rights reserved.
10 * 10 *
(...skipping 28 matching lines...) Expand all
39 #include "core/dom/DocumentSupplementable.h" 39 #include "core/dom/DocumentSupplementable.h"
40 #include "core/dom/DocumentTiming.h" 40 #include "core/dom/DocumentTiming.h"
41 #include "core/dom/ExecutionContext.h" 41 #include "core/dom/ExecutionContext.h"
42 #include "core/dom/MutationObserver.h" 42 #include "core/dom/MutationObserver.h"
43 #include "core/dom/TextLinkColors.h" 43 #include "core/dom/TextLinkColors.h"
44 #include "core/dom/TreeScope.h" 44 #include "core/dom/TreeScope.h"
45 #include "core/dom/UserActionElementSet.h" 45 #include "core/dom/UserActionElementSet.h"
46 #include "core/dom/ViewportDescription.h" 46 #include "core/dom/ViewportDescription.h"
47 #include "core/dom/custom/CustomElement.h" 47 #include "core/dom/custom/CustomElement.h"
48 #include "core/html/CollectionType.h" 48 #include "core/html/CollectionType.h"
49 #include "core/inspector/ConsoleMessage.h"
vsevik 2014/08/08 17:04:00 Forward declaration here?
kozyatinskiy1 2014/08/08 17:17:00 Done.
49 #include "core/page/FocusType.h" 50 #include "core/page/FocusType.h"
50 #include "core/page/PageVisibilityState.h" 51 #include "core/page/PageVisibilityState.h"
51 #include "platform/Length.h" 52 #include "platform/Length.h"
52 #include "platform/Timer.h" 53 #include "platform/Timer.h"
53 #include "platform/heap/Handle.h" 54 #include "platform/heap/Handle.h"
54 #include "platform/weborigin/KURL.h" 55 #include "platform/weborigin/KURL.h"
55 #include "platform/weborigin/ReferrerPolicy.h" 56 #include "platform/weborigin/ReferrerPolicy.h"
56 #include "wtf/HashSet.h" 57 #include "wtf/HashSet.h"
57 #include "wtf/OwnPtr.h" 58 #include "wtf/OwnPtr.h"
58 #include "wtf/PassOwnPtr.h" 59 #include "wtf/PassOwnPtr.h"
(...skipping 946 matching lines...) Expand 10 before | Expand all | Expand 10 after
1005 const WillBeHeapVector<RefPtrWillBeMember<Element> >& topLayerElements() con st { return m_topLayerElements; } 1006 const WillBeHeapVector<RefPtrWillBeMember<Element> >& topLayerElements() con st { return m_topLayerElements; }
1006 HTMLDialogElement* activeModalDialog() const; 1007 HTMLDialogElement* activeModalDialog() const;
1007 1008
1008 // A non-null m_templateDocumentHost implies that |this| was created by ensu reTemplateDocument(). 1009 // A non-null m_templateDocumentHost implies that |this| was created by ensu reTemplateDocument().
1009 bool isTemplateDocument() const { return !!m_templateDocumentHost; } 1010 bool isTemplateDocument() const { return !!m_templateDocumentHost; }
1010 Document& ensureTemplateDocument(); 1011 Document& ensureTemplateDocument();
1011 Document* templateDocumentHost() { return m_templateDocumentHost; } 1012 Document* templateDocumentHost() { return m_templateDocumentHost; }
1012 1013
1013 void didAssociateFormControl(Element*); 1014 void didAssociateFormControl(Element*);
1014 1015
1015 void addConsoleMessageWithRequestIdentifier(MessageSource, MessageLevel, con st String& message, unsigned long requestIdentifier); 1016 virtual void addMessage(PassRefPtr<ConsoleMessage>) OVERRIDE FINAL;
1016 1017
1017 virtual LocalDOMWindow* executingWindow() OVERRIDE FINAL; 1018 virtual LocalDOMWindow* executingWindow() OVERRIDE FINAL;
1018 LocalFrame* executingFrame(); 1019 LocalFrame* executingFrame();
1019 1020
1020 DocumentLifecycleNotifier& lifecycleNotifier(); 1021 DocumentLifecycleNotifier& lifecycleNotifier();
1021 DocumentLifecycle& lifecycle() { return m_lifecycle; } 1022 DocumentLifecycle& lifecycle() { return m_lifecycle; }
1022 bool isActive() const { return m_lifecycle.isActive(); } 1023 bool isActive() const { return m_lifecycle.isActive(); }
1023 bool isStopped() const { return m_lifecycle.state() == DocumentLifecycle::St opped; } 1024 bool isStopped() const { return m_lifecycle.state() == DocumentLifecycle::St opped; }
1024 bool isDisposed() const { return m_lifecycle.state() == DocumentLifecycle::D isposed; } 1025 bool isDisposed() const { return m_lifecycle.state() == DocumentLifecycle::D isposed; }
1025 1026
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
1108 1109
1109 #if !ENABLE(OILPAN) 1110 #if !ENABLE(OILPAN)
1110 virtual void refExecutionContext() OVERRIDE FINAL { ref(); } 1111 virtual void refExecutionContext() OVERRIDE FINAL { ref(); }
1111 virtual void derefExecutionContext() OVERRIDE FINAL { deref(); } 1112 virtual void derefExecutionContext() OVERRIDE FINAL { deref(); }
1112 #endif 1113 #endif
1113 1114
1114 virtual const KURL& virtualURL() const OVERRIDE FINAL; // Same as url(), but needed for ExecutionContext to implement it without a performance loss for dire ct calls. 1115 virtual const KURL& virtualURL() const OVERRIDE FINAL; // Same as url(), but needed for ExecutionContext to implement it without a performance loss for dire ct calls.
1115 virtual KURL virtualCompleteURL(const String&) const OVERRIDE FINAL; // Same as completeURL() for the same reason as above. 1116 virtual KURL virtualCompleteURL(const String&) const OVERRIDE FINAL; // Same as completeURL() for the same reason as above.
1116 1117
1117 virtual void reportBlockedScriptExecutionToInspector(const String& directive Text) OVERRIDE FINAL; 1118 virtual void reportBlockedScriptExecutionToInspector(const String& directive Text) OVERRIDE FINAL;
1118 virtual void addMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, ScriptState*) OVERRIDE FINAL;
1119 void internalAddMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber, PassRefPtrWillBeRawPtr<ScriptCallS tack>, ScriptState*);
1120 1119
1121 virtual double timerAlignmentInterval() const OVERRIDE FINAL; 1120 virtual double timerAlignmentInterval() const OVERRIDE FINAL;
1122 1121
1123 void updateTitle(const String&); 1122 void updateTitle(const String&);
1124 void updateFocusAppearanceTimerFired(Timer<Document>*); 1123 void updateFocusAppearanceTimerFired(Timer<Document>*);
1125 void updateBaseURL(); 1124 void updateBaseURL();
1126 1125
1127 void executeScriptsWaitingForResourcesTimerFired(Timer<Document>*); 1126 void executeScriptsWaitingForResourcesTimerFired(Timer<Document>*);
1128 1127
1129 void loadEventDelayTimerFired(Timer<Document>*); 1128 void loadEventDelayTimerFired(Timer<Document>*);
(...skipping 292 matching lines...) Expand 10 before | Expand all | Expand 10 after
1422 Node* eventTargetNodeForDocument(Document*); 1421 Node* eventTargetNodeForDocument(Document*);
1423 1422
1424 } // namespace blink 1423 } // namespace blink
1425 1424
1426 #ifndef NDEBUG 1425 #ifndef NDEBUG
1427 // Outside the WebCore namespace for ease of invocation from gdb. 1426 // Outside the WebCore namespace for ease of invocation from gdb.
1428 void showLiveDocumentInstances(); 1427 void showLiveDocumentInstances();
1429 #endif 1428 #endif
1430 1429
1431 #endif // Document_h 1430 #endif // Document_h
OLDNEW
« no previous file with comments | « Source/core/dom/AddConsoleMessageTask.cpp ('k') | Source/core/dom/Document.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698