Source/core/dom/ExecutionContext.h - Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ExecutionContext.h

Issue 419203004: DevTools: wrapping arguments addConsoleMessage in ConsoleMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@wrap-not-all-console-args

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ExecutionContext.h

diff --git a/Source/core/dom/ExecutionContext.h b/Source/core/dom/ExecutionContext.h

index ccb887733cefe46d789cb35d8b1f7b96b33f70c9..a43a9a139f8d6ea285197dcfcaec827eae7802f9 100644

--- a/Source/core/dom/ExecutionContext.h

+++ b/Source/core/dom/ExecutionContext.h

@@ -35,6 +35,7 @@

#include "core/fetch/CrossOriginAccessControl.h"

#include "core/frame/ConsoleTypes.h"

#include "core/frame/DOMTimer.h"

+#include "core/inspector/ConsoleMessage.h"

#include "platform/LifecycleContext.h"

#include "platform/Supplementable.h"

#include "platform/heap/Handle.h"

@@ -84,8 +85,7 @@ public:

bool shouldSanitizeScriptError(const String& sourceURL, AccessControlStatus);

void reportException(PassRefPtrWillBeRawPtr<ErrorEvent>, PassRefPtrWillBeRawPtr<ScriptCallStack>, AccessControlStatus);

- void addConsoleMessage(MessageSource, MessageLevel, const String& message, const String& sourceURL, unsigned lineNumber);

- void addConsoleMessage(MessageSource, MessageLevel, const String& message, ScriptState* = 0);

+ void addConsoleMessage(PassRefPtr<ConsoleMessage>);

PublicURLManager& publicURLManager();

« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/dom/ExecutionContext.cpp » ('j') | no next file with comments »