Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 414863002: Minimize RenderObject* casting to RenderText* (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 4 months ago
Reviewers:
pdr., esprehn
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-rendering, caseq+blink_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, krit, eae+blinkwatch, ed+blinkwatch_opera.com, eustas+blink_chromium.org, f(malita), fs, gyuyoung.kim_webkit.org, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pdr., pfeldman+blink_chromium.org, rwlbuis, rune+blink, Stephen Chennney, sergeyv+blink_chromium.org, sof, vsevik+blink_chromium.org, yurys+blink_chromium.org, zoltan1
Project:
blink
Visibility:
Public.

Description

Minimize RenderObject* casting to RenderText* Minimize RenderObject* casting to RenderText* by providing renderer() methods on Text and InlineTextBox that return a RenderText. This hides the more generic renderer() methods in their parent that return a RenderObject. This is inspired by WebKit r157373 by antti@apple.com: https://trac.webkit.org/r157373 R=esprehn@chromium.org, pdr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178991

Patch Set 1 #

Patch Set 2 : Stop including RenderText.h in Text.h #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -98 lines) Patch
M Source/core/dom/Range.cpp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/dom/Text.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Text.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/HTMLInterchange.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/InsertIntoTextNodeCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/InsertLineBreakCommand.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/page/TouchAdjustment.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/InlineFlowBox.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/InlineTextBox.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/core/rendering/InlineTextBox.cpp View 24 chunks +34 lines, -34 lines 0 comments Download
M Source/core/rendering/RenderBlock.h View 1 2 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderBlock.cpp View 1 2 4 chunks +11 lines, -12 lines 0 comments Download
M Source/core/rendering/RenderText.h View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGRootInlineBox.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextChunkBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/SVGTextLayoutEngine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGTextQuery.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
Inactive
6 years, 5 months ago (2014-07-23 21:42:48 UTC) #1
esprehn
This makes Text.h pull in RenderText.h, which then means we pull in tons of the ...
6 years, 5 months ago (2014-07-23 22:20:55 UTC) #2
Inactive
On 2014/07/23 22:20:55, esprehn wrote: > This makes Text.h pull in RenderText.h, which then means ...
6 years, 5 months ago (2014-07-23 23:20:26 UTC) #3
esprehn
lgtm
6 years, 4 months ago (2014-07-27 16:45:48 UTC) #4
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-27 17:07:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/414863002/20001
6 years, 4 months ago (2014-07-27 17:07:23 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 4 months ago (2014-07-27 17:59:24 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-27 18:01:43 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/11185)
6 years, 4 months ago (2014-07-27 18:01:44 UTC) #9
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-27 18:29:23 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/414863002/40001
6 years, 4 months ago (2014-07-27 18:29:52 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-07-27 19:13:44 UTC) #12
Message was sent while issue was closed.
Change committed as 178991

Powered by Google App Engine
This is Rietveld 408576698