Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: Source/core/rendering/svg/SVGRenderTreeAsText.cpp

Issue 414863002: Minimize RenderObject* casting to RenderText* (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2007, 2009 Apple Inc. All rights reserved.
3 * (C) 2005 Rob Buis <buis@kde.org> 3 * (C) 2005 Rob Buis <buis@kde.org>
4 * (C) 2006 Alexander Kellett <lypanov@kde.org> 4 * (C) 2006 Alexander Kellett <lypanov@kde.org>
5 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 5 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
395 if (text.parent() && (text.parent()->style()->visitedDependentColor(CSSPrope rtyColor) != text.style()->visitedDependentColor(CSSPropertyColor))) 395 if (text.parent() && (text.parent()->style()->visitedDependentColor(CSSPrope rtyColor) != text.style()->visitedDependentColor(CSSPropertyColor)))
396 writeNameValuePair(ts, "color", text.resolveColor(CSSPropertyColor).name ForRenderTreeAsText()); 396 writeNameValuePair(ts, "color", text.resolveColor(CSSPropertyColor).name ForRenderTreeAsText());
397 } 397 }
398 398
399 static inline void writeSVGInlineTextBox(TextStream& ts, SVGInlineTextBox* textB ox, int indent) 399 static inline void writeSVGInlineTextBox(TextStream& ts, SVGInlineTextBox* textB ox, int indent)
400 { 400 {
401 Vector<SVGTextFragment>& fragments = textBox->textFragments(); 401 Vector<SVGTextFragment>& fragments = textBox->textFragments();
402 if (fragments.isEmpty()) 402 if (fragments.isEmpty())
403 return; 403 return;
404 404
405 RenderSVGInlineText& textRenderer = toRenderSVGInlineText(textBox->textRende rer()); 405 RenderSVGInlineText& textRenderer = toRenderSVGInlineText(textBox->renderer( ));
406 406
407 const SVGRenderStyle& svgStyle = textRenderer.style()->svgStyle(); 407 const SVGRenderStyle& svgStyle = textRenderer.style()->svgStyle();
408 String text = textBox->textRenderer().text(); 408 String text = textBox->renderer().text();
409 409
410 unsigned fragmentsSize = fragments.size(); 410 unsigned fragmentsSize = fragments.size();
411 for (unsigned i = 0; i < fragmentsSize; ++i) { 411 for (unsigned i = 0; i < fragmentsSize; ++i) {
412 SVGTextFragment& fragment = fragments.at(i); 412 SVGTextFragment& fragment = fragments.at(i);
413 writeIndent(ts, indent + 1); 413 writeIndent(ts, indent + 1);
414 414
415 unsigned startOffset = fragment.characterOffset; 415 unsigned startOffset = fragment.characterOffset;
416 unsigned endOffset = fragment.characterOffset + fragment.length; 416 unsigned endOffset = fragment.characterOffset + fragment.length;
417 417
418 // FIXME: Remove this hack, once the new text layout engine is completly landed. We want to preserve the old layout test results for now. 418 // FIXME: Remove this hack, once the new text layout engine is completly landed. We want to preserve the old layout test results for now.
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
673 ts << " "; 673 ts << " ";
674 writeNameAndQuotedValue(ts, "filter", svgStyle.filterResource()); 674 writeNameAndQuotedValue(ts, "filter", svgStyle.filterResource());
675 ts << " "; 675 ts << " ";
676 writeStandardPrefix(ts, *filter, 0); 676 writeStandardPrefix(ts, *filter, 0);
677 ts << " " << filter->resourceBoundingBox(&renderer) << "\n"; 677 ts << " " << filter->resourceBoundingBox(&renderer) << "\n";
678 } 678 }
679 } 679 }
680 } 680 }
681 681
682 } // namespace blink 682 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/SVGInlineTextBox.cpp ('k') | Source/core/rendering/svg/SVGRootInlineBox.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698