Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: Source/core/dom/Range.cpp

Issue 414863002: Minimize RenderObject* casting to RenderText* (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/Text.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * (C) 1999 Lars Knoll (knoll@kde.org) 2 * (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Gunnstein Lye (gunnstein@netcom.no) 3 * (C) 2000 Gunnstein Lye (gunnstein@netcom.no)
4 * (C) 2000 Frederik Holljen (frederik.holljen@hig.no) 4 * (C) 2000 Frederik Holljen (frederik.holljen@hig.no)
5 * (C) 2001 Peter Kelly (pmk@post.com) 5 * (C) 2001 Peter Kelly (pmk@post.com)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
7 * Copyright (C) 2011 Motorola Mobility. All rights reserved. 7 * Copyright (C) 2011 Motorola Mobility. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1641 matching lines...) Expand 10 before | Expand all | Expand 10 after
1652 if (!nodeSet.contains(node->parentNode())) { 1652 if (!nodeSet.contains(node->parentNode())) {
1653 if (RenderBoxModelObject* renderBoxModelObject = toElement(node) ->renderBoxModelObject()) { 1653 if (RenderBoxModelObject* renderBoxModelObject = toElement(node) ->renderBoxModelObject()) {
1654 Vector<FloatQuad> elementQuads; 1654 Vector<FloatQuad> elementQuads;
1655 renderBoxModelObject->absoluteQuads(elementQuads); 1655 renderBoxModelObject->absoluteQuads(elementQuads);
1656 m_ownerDocument->adjustFloatQuadsForScrollAndAbsoluteZoom(el ementQuads, *renderBoxModelObject); 1656 m_ownerDocument->adjustFloatQuadsForScrollAndAbsoluteZoom(el ementQuads, *renderBoxModelObject);
1657 1657
1658 quads.appendVector(elementQuads); 1658 quads.appendVector(elementQuads);
1659 } 1659 }
1660 } 1660 }
1661 } else if (node->isTextNode()) { 1661 } else if (node->isTextNode()) {
1662 if (RenderObject* renderer = toText(node)->renderer()) { 1662 if (RenderText* renderText = toText(node)->renderer()) {
1663 RenderText& renderText = toRenderText(*renderer);
1664 int startOffset = (node == startContainer) ? m_start.offset() : 0; 1663 int startOffset = (node == startContainer) ? m_start.offset() : 0;
1665 int endOffset = (node == endContainer) ? m_end.offset() : INT_MA X; 1664 int endOffset = (node == endContainer) ? m_end.offset() : INT_MA X;
1666 1665
1667 Vector<FloatQuad> textQuads; 1666 Vector<FloatQuad> textQuads;
1668 renderText.absoluteQuadsForRange(textQuads, startOffset, endOffs et); 1667 renderText->absoluteQuadsForRange(textQuads, startOffset, endOff set);
1669 m_ownerDocument->adjustFloatQuadsForScrollAndAbsoluteZoom(textQu ads, renderText); 1668 m_ownerDocument->adjustFloatQuadsForScrollAndAbsoluteZoom(textQu ads, *renderText);
1670 1669
1671 quads.appendVector(textQuads); 1670 quads.appendVector(textQuads);
1672 } 1671 }
1673 } 1672 }
1674 } 1673 }
1675 } 1674 }
1676 1675
1677 FloatRect Range::boundingRect() const 1676 FloatRect Range::boundingRect() const
1678 { 1677 {
1679 m_ownerDocument->updateLayoutIgnorePendingStylesheets(); 1678 m_ownerDocument->updateLayoutIgnorePendingStylesheets();
(...skipping 23 matching lines...) Expand all
1703 1702
1704 void showTree(const blink::Range* range) 1703 void showTree(const blink::Range* range)
1705 { 1704 {
1706 if (range && range->boundaryPointsValid()) { 1705 if (range && range->boundaryPointsValid()) {
1707 range->startContainer()->showTreeAndMark(range->startContainer(), "S", r ange->endContainer(), "E"); 1706 range->startContainer()->showTreeAndMark(range->startContainer(), "S", r ange->endContainer(), "E");
1708 fprintf(stderr, "start offset: %d, end offset: %d\n", range->startOffset (), range->endOffset()); 1707 fprintf(stderr, "start offset: %d, end offset: %d\n", range->startOffset (), range->endOffset());
1709 } 1708 }
1710 } 1709 }
1711 1710
1712 #endif 1711 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/Text.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698