Source/core/rendering/svg/SVGRootInlineBox.cpp - Issue 414863002: Minimize RenderObject* casting to RenderText*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGRootInlineBox.cpp

Issue 414863002: Minimize RenderObject* casting to RenderText* (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGRootInlineBox.cpp

diff --git a/Source/core/rendering/svg/SVGRootInlineBox.cpp b/Source/core/rendering/svg/SVGRootInlineBox.cpp

index bad09ebefd6c0ec398db138aa5458155ead66510..cd9ff730f7ac6ff629ed5a04c89c41d81f0ea8c8 100644

--- a/Source/core/rendering/svg/SVGRootInlineBox.cpp

+++ b/Source/core/rendering/svg/SVGRootInlineBox.cpp

@@ -259,8 +259,8 @@ static inline void reverseInlineBoxRangeAndValueListsIfNeeded(void* userData, Ve

// Reordering is only necessary for BiDi text that is _absolutely_ positioned.

if (firstTextBox->len() == 1 && firstTextBox->len() == lastTextBox->len()) {

- RenderSVGInlineText& firstContext = toRenderSVGInlineText(firstTextBox->textRenderer());

- RenderSVGInlineText& lastContext = toRenderSVGInlineText(lastTextBox->textRenderer());

+ RenderSVGInlineText& firstContext = toRenderSVGInlineText(firstTextBox->renderer());

+ RenderSVGInlineText& lastContext = toRenderSVGInlineText(lastTextBox->renderer());

SVGTextLayoutAttributes* firstAttributes = 0;

SVGTextLayoutAttributes* lastAttributes = 0;