Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 413983006: Revert 285209 "Cleanups for aura/test/event_generator.h (resolve..." (Closed)

Created:
6 years, 5 months ago by markusheintz_
Modified:
6 years, 5 months ago
Reviewers:
tapted
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 285209 "Cleanups for aura/test/event_generator.h (resolve..." > Cleanups for aura/test/event_generator.h (resolve TODOs) > > Some purely mechanical changes left over from r283694, now that > aura::test::EventGenerator has moved to ui::test in src/ui/events. > > Moves aura/test/event_generator.* to event_generator_delegate_aura.* > Removes `using ui::test::EventGenerator;` declaration and redirects > includes that don't extend the delegate to include the ui/test > event_generator.h directly > > BUG=378134 > > Review URL: https://codereview.chromium.org/406413004 TBR=tapted@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285222

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+458 lines, -618 lines) Patch
M trunk/src/ash/accelerators/accelerator_controller_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ash/accelerators/accelerator_filter_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ash/accelerators/magnifier_key_scroller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/accelerators/spoken_feedback_toggler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/autoclick/autoclick_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/display/display_controller_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/ash/display/display_manager_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/ash/display/mirror_window_controller_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ash/display/root_window_transformers_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/ash/drag_drop/drag_drop_controller_unittest.cc View 15 chunks +25 lines, -25 lines 0 comments Download
M trunk/src/ash/extended_desktop_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M trunk/src/ash/first_run/first_run_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/focus_cycler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/frame/caption_buttons/frame_size_button_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/ash/ime/candidate_view_unittest.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M trunk/src/ash/magnifier/magnification_controller_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/ash/root_window_controller_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/ash/shelf/shelf_layout_manager_unittest.cc View 16 chunks +21 lines, -21 lines 0 comments Download
M trunk/src/ash/shelf/shelf_view_unittest.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/ash/shell_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/system/tray/system_tray_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/ash/system/user/tray_user_unittest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M trunk/src/ash/system/web_notification/web_notification_tray_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/test/ash_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ash/tooltips/tooltip_controller_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ash/wm/app_list_controller_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M trunk/src/ash/wm/dock/docked_window_resizer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/wm/gestures/overview_gesture_handler_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/ash/wm/immersive_fullscreen_controller_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/ash/wm/lock_state_controller_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M trunk/src/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/ash/wm/overview/window_selector_unittest.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M trunk/src/ash/wm/panels/panel_layout_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ash/wm/partial_screenshot_view_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ash/wm/resize_shadow_and_cursor_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M trunk/src/ash/wm/system_gesture_event_filter_unittest.cc View 10 chunks +14 lines, -9 lines 0 comments Download
M trunk/src/ash/wm/system_modal_container_layout_manager_unittest.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/ash/wm/toplevel_window_event_handler_unittest.cc View 16 chunks +29 lines, -28 lines 0 comments Download
M trunk/src/ash/wm/window_manager_unittest.cc View 11 chunks +16 lines, -12 lines 0 comments Download
M trunk/src/ash/wm/window_modality_controller_unittest.cc View 9 chunks +13 lines, -13 lines 0 comments Download
M trunk/src/ash/wm/workspace/multi_window_resize_controller_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/ash/wm/workspace/workspace_event_handler_unittest.cc View 14 chunks +19 lines, -19 lines 0 comments Download
M trunk/src/ash/wm/workspace/workspace_window_resizer_unittest.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M trunk/src/ash/wm/workspace_controller_unittest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M trunk/src/athena/input/accelerator_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 4 chunks +5 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/content/browser/web_contents/aura/window_slider_unittest.cc View 10 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_view_aura_browsertest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M trunk/src/ui/aura/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ui/aura/aura.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/src/ui/aura/gestures/gesture_recognizer_unittest.cc View 6 chunks +5 lines, -5 lines 0 comments Download
A + trunk/src/ui/aura/test/event_generator.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ui/aura/test/event_generator.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
D trunk/src/ui/aura/test/event_generator_delegate_aura.h View 1 chunk +0 lines, -55 lines 0 comments Download
D trunk/src/ui/aura/test/event_generator_delegate_aura.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M trunk/src/ui/aura/window_event_dispatcher_unittest.cc View 14 chunks +16 lines, -16 lines 0 comments Download
M trunk/src/ui/aura/window_unittest.cc View 13 chunks +12 lines, -12 lines 0 comments Download
M trunk/src/ui/chromeos/touch_exploration_controller_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ui/keyboard/keyboard_controller_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ui/views/corewm/capture_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ui/views/corewm/desktop_capture_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ui/views/corewm/tooltip_controller_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M trunk/src/ui/views/touchui/touch_selection_controller_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M trunk/src/ui/views/widget/widget_interactive_uitest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/ui/wm/core/compound_event_filter_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M trunk/src/ui/wm/core/focus_controller_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M trunk/src/ui/wm/core/input_method_event_filter_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
markusheintz_
6 years, 5 months ago (2014-07-24 13:17:30 UTC) #1
markusheintz_
Committed patchset #1 manually as r285222 (tree was closed).
6 years, 5 months ago (2014-07-24 13:18:45 UTC) #2
tapted
6 years, 5 months ago (2014-07-24 13:20:16 UTC) #3
Message was sent while issue was closed.
lgtm - thanks

Powered by Google App Engine
This is Rietveld 408576698