Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 406413004: Cleanups for aura/test/event_generator.h (resolve TODOs) (Closed)

Created:
6 years, 5 months ago by tapted
Modified:
6 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, dcheng, sievers+watch_chromium.org, yukishiino+watch_chromium.org, yusukes+watch_chromium.org, dmazzoni+watch_chromium.org, ben+aura_chromium.org, stevenjb+watch_chromium.org, miu+watch_chromium.org, tdanderson+views_chromium.org, aboxhall+watch_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, ben+corewm_chromium.org, kalyank, tdanderson+overview_chromium.org, penghuang+watch_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, ben+views_chromium.org, plundblad+watch_chromium.org, tfarina, ben+ash_chromium.org, dtseng+watch_chromium.org, danakj+watch_chromium.org, James Su, davemoore+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Cleanups for aura/test/event_generator.h (resolve TODOs) Some purely mechanical changes left over from r283694, now that aura::test::EventGenerator has moved to ui::test in src/ui/events. Moves aura/test/event_generator.* to event_generator_delegate_aura.* Removes `using ui::test::EventGenerator;` declaration and redirects includes that don't extend the delegate to include the ui/test event_generator.h directly BUG=378134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285209 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285857

Patch Set 1 : just move_source_file.py #

Patch Set 2 : various find | xargs | sed -i calls. sort headers. git cl format. #

Patch Set 3 : fix compile #

Patch Set 4 : fix gn #

Total comments: 1

Patch Set 5 : Just a rebase #

Patch Set 6 : fix for added files #

Total comments: 2

Patch Set 7 : rebase at r285842 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+459 lines, -655 lines) Patch
M ash/accelerators/accelerator_controller_unittest.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M ash/accelerators/accelerator_filter_unittest.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M ash/accelerators/magnifier_key_scroller_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M ash/accelerators/spoken_feedback_toggler_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/autoclick/autoclick_unittest.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 1 2 3 4 7 chunks +7 lines, -7 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
M ash/display/mirror_window_controller_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 15 chunks +25 lines, -25 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 1 11 chunks +11 lines, -11 lines 0 comments Download
M ash/first_run/first_run_helper_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/focus_cycler_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 1 9 chunks +9 lines, -9 lines 0 comments Download
M ash/ime/candidate_view_unittest.cc View 1 4 chunks +4 lines, -6 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 16 chunks +21 lines, -21 lines 0 comments Download
M ash/shelf/shelf_view_unittest.cc View 1 5 chunks +7 lines, -7 lines 0 comments Download
M ash/shell_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/tray/system_tray_unittest.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M ash/system/user/tray_user_unittest.cc View 1 7 chunks +11 lines, -11 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/app_list_controller_unittest.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/gestures/overview_gesture_handler_unittest.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller_unittest.cc View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 8 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 6 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/partial_screenshot_view_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/resize_shadow_and_cursor_unittest.cc View 1 5 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 10 chunks +9 lines, -14 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 9 chunks +10 lines, -10 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 1 16 chunks +28 lines, -29 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 2 3 4 5 6 11 chunks +12 lines, -16 lines 0 comments Download
M ash/wm/window_modality_controller_unittest.cc View 1 9 chunks +13 lines, -13 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller_unittest.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 14 chunks +19 lines, -19 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 6 chunks +10 lines, -10 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 7 chunks +11 lines, -11 lines 0 comments Download
M athena/home/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M athena/home/home_card_unittest.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M athena/input/accelerator_manager_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M athena/screen/DEPS View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M athena/screen/screen_manager_unittest.cc View 1 2 3 4 5 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/accessibility/touch_exploration_controller_browsertest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 3 4 5 6 6 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 1 2 3 4 5 6 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 4 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/aura/window_slider_unittest.cc View 1 2 3 4 5 6 10 chunks +9 lines, -9 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 2 3 4 5 6 6 chunks +6 lines, -6 lines 0 comments Download
M ui/aura/BUILD.gn View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 2 6 chunks +5 lines, -5 lines 0 comments Download
D ui/aura/test/event_generator.h View 1 chunk +0 lines, -61 lines 0 comments Download
D ui/aura/test/event_generator.cc View 1 chunk +0 lines, -118 lines 0 comments Download
A + ui/aura/test/event_generator_delegate_aura.h View 2 chunks +3 lines, -9 lines 0 comments Download
A + ui/aura/test/event_generator_delegate_aura.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 2 3 4 5 6 14 chunks +16 lines, -16 lines 0 comments Download
M ui/aura/window_unittest.cc View 1 2 3 4 5 6 13 chunks +12 lines, -12 lines 0 comments Download
M ui/chromeos/touch_exploration_controller_unittest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/capture_controller_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/desktop_capture_controller_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/wm/core/compound_event_filter_unittest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M ui/wm/core/focus_controller_unittest.cc View 1 6 chunks +9 lines, -9 lines 0 comments Download
M ui/wm/core/input_method_event_filter_unittest.cc View 1 2 3 4 5 6 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
tapted
Hi sky since you're an owner in src/ash as well, could you please take a ...
6 years, 5 months ago (2014-07-23 11:44:39 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-23 16:39:39 UTC) #2
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 5 months ago (2014-07-23 23:41:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/406413004/60001
6 years, 5 months ago (2014-07-23 23:43:39 UTC) #4
tapted
The CQ bit was unchecked by tapted@chromium.org
6 years, 5 months ago (2014-07-24 05:36:50 UTC) #5
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 5 months ago (2014-07-24 05:37:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/406413004/60001
6 years, 5 months ago (2014-07-24 05:39:19 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-24 06:22:27 UTC) #8
commit-bot: I haz the power
Change committed as 285209
6 years, 5 months ago (2014-07-24 12:34:46 UTC) #9
tapted
Hi sky - PTAL for some DEPS changes that are now required in athena [links ...
6 years, 5 months ago (2014-07-25 06:28:19 UTC) #10
sky
LGTM
6 years, 5 months ago (2014-07-25 16:07:52 UTC) #11
tapted
The CQ bit was checked by tapted@chromium.org
6 years, 4 months ago (2014-07-27 22:58:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/406413004/140001
6 years, 4 months ago (2014-07-27 22:59:24 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_chromium_gn_compile_rel on tryserver.chromium.linux ...
6 years, 4 months ago (2014-07-28 00:50:24 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 01:49:00 UTC) #15
Message was sent while issue was closed.
Change committed as 285857

Powered by Google App Engine
This is Rietveld 408576698