Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Side by Side Diff: ash/accelerators/accelerator_controller_unittest.cc

Issue 406413004: Cleanups for aura/test/event_generator.h (resolve TODOs) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase at r285842 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | ash/accelerators/accelerator_filter_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/accelerators/accelerator_controller.h" 5 #include "ash/accelerators/accelerator_controller.h"
6 6
7 #include "ash/accelerators/accelerator_table.h" 7 #include "ash/accelerators/accelerator_table.h"
8 #include "ash/accessibility_delegate.h" 8 #include "ash/accessibility_delegate.h"
9 #include "ash/ash_switches.h" 9 #include "ash/ash_switches.h"
10 #include "ash/display/display_manager.h" 10 #include "ash/display/display_manager.h"
11 #include "ash/ime_control_delegate.h" 11 #include "ash/ime_control_delegate.h"
12 #include "ash/screen_util.h" 12 #include "ash/screen_util.h"
13 #include "ash/shell.h" 13 #include "ash/shell.h"
14 #include "ash/shell_window_ids.h" 14 #include "ash/shell_window_ids.h"
15 #include "ash/system/brightness_control_delegate.h" 15 #include "ash/system/brightness_control_delegate.h"
16 #include "ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h" 16 #include "ash/system/keyboard_brightness/keyboard_brightness_control_delegate.h"
17 #include "ash/system/tray/system_tray_delegate.h" 17 #include "ash/system/tray/system_tray_delegate.h"
18 #include "ash/test/ash_test_base.h" 18 #include "ash/test/ash_test_base.h"
19 #include "ash/test/display_manager_test_api.h" 19 #include "ash/test/display_manager_test_api.h"
20 #include "ash/test/test_screenshot_delegate.h" 20 #include "ash/test/test_screenshot_delegate.h"
21 #include "ash/test/test_shell_delegate.h" 21 #include "ash/test/test_shell_delegate.h"
22 #include "ash/test/test_volume_control_delegate.h" 22 #include "ash/test/test_volume_control_delegate.h"
23 #include "ash/volume_control_delegate.h" 23 #include "ash/volume_control_delegate.h"
24 #include "ash/wm/window_state.h" 24 #include "ash/wm/window_state.h"
25 #include "ash/wm/window_util.h" 25 #include "ash/wm/window_util.h"
26 #include "base/command_line.h" 26 #include "base/command_line.h"
27 #include "ui/aura/client/aura_constants.h" 27 #include "ui/aura/client/aura_constants.h"
28 #include "ui/aura/test/event_generator.h"
29 #include "ui/aura/test/test_window_delegate.h" 28 #include "ui/aura/test/test_window_delegate.h"
30 #include "ui/aura/test/test_windows.h" 29 #include "ui/aura/test/test_windows.h"
31 #include "ui/aura/window.h" 30 #include "ui/aura/window.h"
32 #include "ui/events/event.h" 31 #include "ui/events/event.h"
33 #include "ui/events/event_processor.h" 32 #include "ui/events/event_processor.h"
33 #include "ui/events/test/event_generator.h"
34 #include "ui/gfx/screen.h" 34 #include "ui/gfx/screen.h"
35 #include "ui/views/widget/widget.h" 35 #include "ui/views/widget/widget.h"
36 36
37 #if defined(USE_X11) 37 #if defined(USE_X11)
38 #include <X11/Xlib.h> 38 #include <X11/Xlib.h>
39 #include "ui/events/test/events_test_utils_x11.h" 39 #include "ui/events/test/events_test_utils_x11.h"
40 #endif 40 #endif
41 41
42 namespace ash { 42 namespace ash {
43 43
(...skipping 468 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 TEST_F(AcceleratorControllerTest, AutoRepeat) { 512 TEST_F(AcceleratorControllerTest, AutoRepeat) {
513 ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_CONTROL_DOWN); 513 ui::Accelerator accelerator_a(ui::VKEY_A, ui::EF_CONTROL_DOWN);
514 accelerator_a.set_type(ui::ET_KEY_PRESSED); 514 accelerator_a.set_type(ui::ET_KEY_PRESSED);
515 TestTarget target_a; 515 TestTarget target_a;
516 GetController()->Register(accelerator_a, &target_a); 516 GetController()->Register(accelerator_a, &target_a);
517 ui::Accelerator accelerator_b(ui::VKEY_B, ui::EF_CONTROL_DOWN); 517 ui::Accelerator accelerator_b(ui::VKEY_B, ui::EF_CONTROL_DOWN);
518 accelerator_b.set_type(ui::ET_KEY_PRESSED); 518 accelerator_b.set_type(ui::ET_KEY_PRESSED);
519 TestTarget target_b; 519 TestTarget target_b;
520 GetController()->Register(accelerator_b, &target_b); 520 GetController()->Register(accelerator_b, &target_b);
521 521
522 aura::test::EventGenerator& generator = GetEventGenerator(); 522 ui::test::EventGenerator& generator = GetEventGenerator();
523 generator.PressKey(ui::VKEY_A, ui::EF_CONTROL_DOWN); 523 generator.PressKey(ui::VKEY_A, ui::EF_CONTROL_DOWN);
524 generator.ReleaseKey(ui::VKEY_A, ui::EF_CONTROL_DOWN); 524 generator.ReleaseKey(ui::VKEY_A, ui::EF_CONTROL_DOWN);
525 525
526 EXPECT_EQ(1, target_a.accelerator_pressed_count()); 526 EXPECT_EQ(1, target_a.accelerator_pressed_count());
527 EXPECT_EQ(0, target_a.accelerator_repeat_count()); 527 EXPECT_EQ(0, target_a.accelerator_repeat_count());
528 528
529 // Long press should generate one 529 // Long press should generate one
530 generator.PressKey(ui::VKEY_A, ui::EF_CONTROL_DOWN); 530 generator.PressKey(ui::VKEY_A, ui::EF_CONTROL_DOWN);
531 generator.PressKey(ui::VKEY_A, ui::EF_CONTROL_DOWN | ui::EF_IS_REPEAT); 531 generator.PressKey(ui::VKEY_A, ui::EF_CONTROL_DOWN | ui::EF_IS_REPEAT);
532 EXPECT_EQ(2, target_a.accelerator_pressed_count()); 532 EXPECT_EQ(2, target_a.accelerator_pressed_count());
(...skipping 14 matching lines...) Expand all
547 generator.PressKey(ui::VKEY_A, ui::EF_CONTROL_DOWN | ui::EF_IS_REPEAT); 547 generator.PressKey(ui::VKEY_A, ui::EF_CONTROL_DOWN | ui::EF_IS_REPEAT);
548 generator.ReleaseKey(ui::VKEY_A, ui::EF_CONTROL_DOWN); 548 generator.ReleaseKey(ui::VKEY_A, ui::EF_CONTROL_DOWN);
549 549
550 EXPECT_EQ(1, target_b.accelerator_pressed_count()); 550 EXPECT_EQ(1, target_b.accelerator_pressed_count());
551 EXPECT_EQ(0, target_b.accelerator_repeat_count()); 551 EXPECT_EQ(0, target_b.accelerator_repeat_count());
552 EXPECT_EQ(4, target_a.accelerator_pressed_count()); 552 EXPECT_EQ(4, target_a.accelerator_pressed_count());
553 EXPECT_EQ(4, target_a.accelerator_repeat_count()); 553 EXPECT_EQ(4, target_a.accelerator_repeat_count());
554 } 554 }
555 555
556 TEST_F(AcceleratorControllerTest, Previous) { 556 TEST_F(AcceleratorControllerTest, Previous) {
557 aura::test::EventGenerator& generator = GetEventGenerator(); 557 ui::test::EventGenerator& generator = GetEventGenerator();
558 generator.PressKey(ui::VKEY_VOLUME_MUTE, ui::EF_NONE); 558 generator.PressKey(ui::VKEY_VOLUME_MUTE, ui::EF_NONE);
559 generator.ReleaseKey(ui::VKEY_VOLUME_MUTE, ui::EF_NONE); 559 generator.ReleaseKey(ui::VKEY_VOLUME_MUTE, ui::EF_NONE);
560 560
561 EXPECT_EQ(ui::VKEY_VOLUME_MUTE, 561 EXPECT_EQ(ui::VKEY_VOLUME_MUTE,
562 GetController()->previous_accelerator_for_test().key_code()); 562 GetController()->previous_accelerator_for_test().key_code());
563 EXPECT_EQ(ui::EF_NONE, 563 EXPECT_EQ(ui::EF_NONE,
564 GetController()->previous_accelerator_for_test().modifiers()); 564 GetController()->previous_accelerator_for_test().modifiers());
565 565
566 generator.PressKey(ui::VKEY_TAB, ui::EF_CONTROL_DOWN); 566 generator.PressKey(ui::VKEY_TAB, ui::EF_CONTROL_DOWN);
567 generator.ReleaseKey(ui::VKEY_TAB, ui::EF_CONTROL_DOWN); 567 generator.ReleaseKey(ui::VKEY_TAB, ui::EF_CONTROL_DOWN);
(...skipping 13 matching lines...) Expand all
581 581
582 views::Widget::InitParams params(views::Widget::InitParams::TYPE_WINDOW); 582 views::Widget::InitParams params(views::Widget::InitParams::TYPE_WINDOW);
583 params.context = CurrentContext(); 583 params.context = CurrentContext();
584 params.bounds = gfx::Rect(5, 5, 20, 20); 584 params.bounds = gfx::Rect(5, 5, 20, 20);
585 views::Widget* widget = new views::Widget; 585 views::Widget* widget = new views::Widget;
586 widget->Init(params); 586 widget->Init(params);
587 widget->Show(); 587 widget->Show();
588 widget->Activate(); 588 widget->Activate();
589 widget->GetNativeView()->SetProperty(aura::client::kCanMaximizeKey, true); 589 widget->GetNativeView()->SetProperty(aura::client::kCanMaximizeKey, true);
590 590
591 aura::test::EventGenerator& generator = GetEventGenerator(); 591 ui::test::EventGenerator& generator = GetEventGenerator();
592 wm::WindowState* window_state = wm::GetWindowState(widget->GetNativeView()); 592 wm::WindowState* window_state = wm::GetWindowState(widget->GetNativeView());
593 593
594 // Toggling not suppressed. 594 // Toggling not suppressed.
595 generator.PressKey(ui::VKEY_J, ui::EF_ALT_DOWN); 595 generator.PressKey(ui::VKEY_J, ui::EF_ALT_DOWN);
596 EXPECT_TRUE(window_state->IsFullscreen()); 596 EXPECT_TRUE(window_state->IsFullscreen());
597 597
598 // The same accelerator - toggling suppressed. 598 // The same accelerator - toggling suppressed.
599 generator.PressKey(ui::VKEY_J, ui::EF_ALT_DOWN | ui::EF_IS_REPEAT); 599 generator.PressKey(ui::VKEY_J, ui::EF_ALT_DOWN | ui::EF_IS_REPEAT);
600 EXPECT_TRUE(window_state->IsFullscreen()); 600 EXPECT_TRUE(window_state->IsFullscreen());
601 601
(...skipping 642 matching lines...) Expand 10 before | Expand all | Expand 10 after
1244 window.reset(CreateTestWindowInShellWithBounds(gfx::Rect(5, 5, 20, 20))); 1244 window.reset(CreateTestWindowInShellWithBounds(gfx::Rect(5, 5, 20, 20)));
1245 wm::ActivateWindow(window.get()); 1245 wm::ActivateWindow(window.get());
1246 GetController()->PerformAction(WINDOW_MINIMIZE, dummy); 1246 GetController()->PerformAction(WINDOW_MINIMIZE, dummy);
1247 delegate->TriggerAccessibilityAlert(A11Y_ALERT_NONE); 1247 delegate->TriggerAccessibilityAlert(A11Y_ALERT_NONE);
1248 GetController()->PerformAction(kActionsNeedingWindow[i], dummy); 1248 GetController()->PerformAction(kActionsNeedingWindow[i], dummy);
1249 EXPECT_NE(delegate->GetLastAccessibilityAlert(), A11Y_ALERT_WINDOW_NEEDED); 1249 EXPECT_NE(delegate->GetLastAccessibilityAlert(), A11Y_ALERT_WINDOW_NEEDED);
1250 } 1250 }
1251 } 1251 }
1252 1252
1253 } // namespace ash 1253 } // namespace ash
OLDNEW
« no previous file with comments | « no previous file | ash/accelerators/accelerator_filter_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698