Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: athena/input/accelerator_manager_unittest.cc

Issue 406413004: Cleanups for aura/test/event_generator.h (resolve TODOs) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase at r285842 Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « athena/home/home_card_unittest.cc ('k') | athena/screen/DEPS » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "athena/input/public/accelerator_manager.h" 5 #include "athena/input/public/accelerator_manager.h"
6 6
7 #include "athena/input/public/input_manager.h" 7 #include "athena/input/public/input_manager.h"
8 #include "athena/test/athena_test_base.h" 8 #include "athena/test/athena_test_base.h"
9 #include "ui/aura/test/event_generator.h" 9 #include "ui/events/test/event_generator.h"
10 10
11 namespace athena { 11 namespace athena {
12 namespace { 12 namespace {
13 13
14 const int kInvalidCommandId = -1; 14 const int kInvalidCommandId = -1;
15 15
16 class TestHandler : public AcceleratorHandler { 16 class TestHandler : public AcceleratorHandler {
17 public: 17 public:
18 TestHandler() : fired_command_id_(kInvalidCommandId), enabled_(true) {} 18 TestHandler() : fired_command_id_(kInvalidCommandId), enabled_(true) {}
19 virtual ~TestHandler() {} 19 virtual ~TestHandler() {}
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 {TRIGGER_ON_PRESS, ui::VKEY_D, ui::EF_SHIFT_DOWN, COMMAND_D, 64 {TRIGGER_ON_PRESS, ui::VKEY_D, ui::EF_SHIFT_DOWN, COMMAND_D,
65 AF_RESERVED | AF_NON_AUTO_REPEATABLE}, 65 AF_RESERVED | AF_NON_AUTO_REPEATABLE},
66 {TRIGGER_ON_PRESS, ui::VKEY_E, ui::EF_SHIFT_DOWN, COMMAND_E, AF_NONE}, 66 {TRIGGER_ON_PRESS, ui::VKEY_E, ui::EF_SHIFT_DOWN, COMMAND_E, AF_NONE},
67 }; 67 };
68 AcceleratorManager* accelerator_manager = 68 AcceleratorManager* accelerator_manager =
69 InputManager::Get()->GetAcceleratorManager(); 69 InputManager::Get()->GetAcceleratorManager();
70 TestHandler test_handler; 70 TestHandler test_handler;
71 accelerator_manager->RegisterAccelerators( 71 accelerator_manager->RegisterAccelerators(
72 data, arraysize(data), &test_handler); 72 data, arraysize(data), &test_handler);
73 73
74 aura::test::EventGenerator generator(root_window()); 74 ui::test::EventGenerator generator(root_window());
75 generator.PressKey(ui::VKEY_A, ui::EF_NONE); 75 generator.PressKey(ui::VKEY_A, ui::EF_NONE);
76 EXPECT_EQ(kInvalidCommandId, test_handler.GetFiredCommandIdAndReset()); 76 EXPECT_EQ(kInvalidCommandId, test_handler.GetFiredCommandIdAndReset());
77 77
78 // Trigger on press. 78 // Trigger on press.
79 generator.PressKey(ui::VKEY_A, ui::EF_SHIFT_DOWN); 79 generator.PressKey(ui::VKEY_A, ui::EF_SHIFT_DOWN);
80 EXPECT_EQ(COMMAND_A, test_handler.GetFiredCommandIdAndReset()); 80 EXPECT_EQ(COMMAND_A, test_handler.GetFiredCommandIdAndReset());
81 generator.ReleaseKey(ui::VKEY_A, ui::EF_SHIFT_DOWN); 81 generator.ReleaseKey(ui::VKEY_A, ui::EF_SHIFT_DOWN);
82 EXPECT_EQ(kInvalidCommandId, test_handler.GetFiredCommandIdAndReset()); 82 EXPECT_EQ(kInvalidCommandId, test_handler.GetFiredCommandIdAndReset());
83 83
84 // Trigger on release. 84 // Trigger on release.
(...skipping 25 matching lines...) Expand all
110 generator.PressKey(ui::VKEY_D, ui::EF_SHIFT_DOWN | ui::EF_IS_REPEAT); 110 generator.PressKey(ui::VKEY_D, ui::EF_SHIFT_DOWN | ui::EF_IS_REPEAT);
111 EXPECT_EQ(kInvalidCommandId, test_handler.GetFiredCommandIdAndReset()); 111 EXPECT_EQ(kInvalidCommandId, test_handler.GetFiredCommandIdAndReset());
112 112
113 // TODO(oshima): Add scenario where the key event is consumed by 113 // TODO(oshima): Add scenario where the key event is consumed by
114 // an app. 114 // an app.
115 generator.PressKey(ui::VKEY_E, ui::EF_SHIFT_DOWN); 115 generator.PressKey(ui::VKEY_E, ui::EF_SHIFT_DOWN);
116 EXPECT_EQ(COMMAND_E, test_handler.GetFiredCommandIdAndReset()); 116 EXPECT_EQ(COMMAND_E, test_handler.GetFiredCommandIdAndReset());
117 } 117 }
118 118
119 } // namespace athena 119 } // namespace athena
OLDNEW
« no previous file with comments | « athena/home/home_card_unittest.cc ('k') | athena/screen/DEPS » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698