Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 399493002: Remove many instances of CreateBooleanValue. (Closed)

Created:
6 years, 5 months ago by Evan Stade
Modified:
6 years, 5 months ago
Reviewers:
Lei Zhang, zel
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, rginda+watch_chromium.org, eroman, dbeam+watch-options_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, estade+watch_chromium.org, chromium-apps-reviews_chromium.org, pedrosimonetti+watch_chromium.org, stevenjb+watch_chromium.org, mmenke, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove many instances of CreateBooleanValue. BUG=160586 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283659

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -76 lines) Patch
M chrome/browser/accessibility/accessibility_extension_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/info_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/wallpaper_private_api.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/proxy_cros_settings_parser.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/web_view/web_view_internal_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/guest_view/web_view/web_view_permission_helper.cc View 5 chunks +10 lines, -15 lines 0 comments Download
M chrome/browser/policy/file_selection_dialogs_policy_handler.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +9 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 2 chunks +8 lines, -11 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/clear_browser_data_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Evan Stade
zelidrag: chrome/browser/chromeos/* thestig: the rest
6 years, 5 months ago (2014-07-15 21:56:38 UTC) #1
Lei Zhang
lgtm
6 years, 5 months ago (2014-07-15 22:00:14 UTC) #2
zel
lgtm
6 years, 5 months ago (2014-07-15 22:31:43 UTC) #3
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-15 22:32:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/399493002/1
6 years, 5 months ago (2014-07-15 22:35:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-16 06:07:01 UTC) #6
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-16 06:07:03 UTC) #7
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 5 months ago (2014-07-16 22:31:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/399493002/20001
6 years, 5 months ago (2014-07-16 22:34:58 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-17 06:28:13 UTC) #10
Message was sent while issue was closed.
Change committed as 283659

Powered by Google App Engine
This is Rietveld 408576698