chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc - Issue 399493002: Remove many instances of CreateBooleanValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

Issue 399493002: Remove many instances of CreateBooleanValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

diff --git a/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc b/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

index e43d41c04ba4ac8e5253ad483a7fe8433b5f2dc2..5fa78ffb1a5a31cd59e9ff8d5a28b2ccd886c64a 100644

--- a/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

+++ b/chrome/browser/ui/webui/performance_monitor/performance_monitor_handler.cc

@@ -451,10 +451,10 @@ void PerformanceMonitorHandler::HandleGetFlagEnabled(

const base::ListValue* args) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

CHECK_EQ(0u, args->GetSize());

- scoped_ptr<base::Value> value(base::Value::CreateBooleanValue(

+ base::FundamentalValue value(

CommandLine::ForCurrentProcess()->HasSwitch(

- switches::kPerformanceMonitorGathering)));

- ReturnResults("PerformanceMonitor.getFlagEnabledCallback", value.get());

+ switches::kPerformanceMonitorGathering));

+ ReturnResults("PerformanceMonitor.getFlagEnabledCallback", &value);

}

void PerformanceMonitorHandler::HandleGetAggregationTypes(

« no previous file with comments | « chrome/browser/ui/webui/options/clear_browser_data_handler.cc ('k') | no next file » | no next file with comments »