chrome/browser/chromeos/proxy_cros_settings_parser.cc - Issue 399493002: Remove many instances of CreateBooleanValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/proxy_cros_settings_parser.cc

Issue 399493002: Remove many instances of CreateBooleanValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/proxy_cros_settings_parser.cc

diff --git a/chrome/browser/chromeos/proxy_cros_settings_parser.cc b/chrome/browser/chromeos/proxy_cros_settings_parser.cc

index 581aeb718facf56fff897460ab5e9351fc483b18..73b5205379fabe2221425c225cce4f1f847251a8 100644

--- a/chrome/browser/chromeos/proxy_cros_settings_parser.cc

+++ b/chrome/browser/chromeos/proxy_cros_settings_parser.cc

@@ -333,11 +333,11 @@ bool GetProxyPrefValue(const UIProxyConfigService& config_service,

break;

}

} else if (path == kProxySingle) {

- data = base::Value::CreateBooleanValue(

- config.mode == UIProxyConfig::MODE_SINGLE_PROXY);

+ data = new base::FundamentalValue(config.mode ==

+ UIProxyConfig::MODE_SINGLE_PROXY);

} else if (path == kProxyUsePacUrl) {

- data = base::Value::CreateBooleanValue(

- config.mode == UIProxyConfig::MODE_PAC_SCRIPT);

+ data = new base::FundamentalValue(config.mode ==

+ UIProxyConfig::MODE_PAC_SCRIPT);

} else if (path == kProxyFtpUrl) {

data = CreateServerHostValue(config.ftp_proxy);

} else if (path == kProxySocks) {