chrome/browser/chromeos/settings/device_settings_provider.cc - Issue 399493002: Remove many instances of CreateBooleanValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider.cc

Issue 399493002: Remove many instances of CreateBooleanValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/settings/device_settings_provider.cc

diff --git a/chrome/browser/chromeos/settings/device_settings_provider.cc b/chrome/browser/chromeos/settings/device_settings_provider.cc

index 7d6366080f07a45237ac838c5021465baf3f17a5..bf85b510524c43e6770f6c350a7e387f0c6d9ea6 100644

--- a/chrome/browser/chromeos/settings/device_settings_provider.cc

+++ b/chrome/browser/chromeos/settings/device_settings_provider.cc

@@ -828,8 +828,7 @@ void DeviceSettingsProvider::ApplyMetricsSetting(bool use_file,

if (use_file) {

new_value = HasOldMetricsFile();

// Make sure the values will get eventually written to the policy file.

- migration_values_.SetValue(kStatsReportingPref,

- base::Value::CreateBooleanValue(new_value));

+ migration_values_.SetBoolean(kStatsReportingPref, new_value);

AttemptMigration();

VLOG(1) << "No metrics policy set will revert to checking "

<< "consent file which is "