Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Side by Side Diff: chrome/browser/policy/file_selection_dialogs_policy_handler.cc

Issue 399493002: Remove many instances of CreateBooleanValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/policy/file_selection_dialogs_policy_handler.h" 5 #include "chrome/browser/policy/file_selection_dialogs_policy_handler.h"
6 6
7 #include "base/prefs/pref_value_map.h" 7 #include "base/prefs/pref_value_map.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chrome/common/pref_names.h" 9 #include "chrome/common/pref_names.h"
10 #include "components/policy/core/common/policy_map.h" 10 #include "components/policy/core/common/policy_map.h"
11 #include "policy/policy_constants.h" 11 #include "policy/policy_constants.h"
12 12
13 namespace policy { 13 namespace policy {
14 14
15 FileSelectionDialogsPolicyHandler::FileSelectionDialogsPolicyHandler() 15 FileSelectionDialogsPolicyHandler::FileSelectionDialogsPolicyHandler()
16 : TypeCheckingPolicyHandler(key::kAllowFileSelectionDialogs, 16 : TypeCheckingPolicyHandler(key::kAllowFileSelectionDialogs,
17 base::Value::TYPE_BOOLEAN) {} 17 base::Value::TYPE_BOOLEAN) {}
18 18
19 FileSelectionDialogsPolicyHandler::~FileSelectionDialogsPolicyHandler() {} 19 FileSelectionDialogsPolicyHandler::~FileSelectionDialogsPolicyHandler() {}
20 20
21 void FileSelectionDialogsPolicyHandler::ApplyPolicySettings( 21 void FileSelectionDialogsPolicyHandler::ApplyPolicySettings(
22 const PolicyMap& policies, 22 const PolicyMap& policies,
23 PrefValueMap* prefs) { 23 PrefValueMap* prefs) {
24 bool allow_dialogs; 24 bool allow_dialogs;
25 const base::Value* value = policies.GetValue(policy_name()); 25 const base::Value* value = policies.GetValue(policy_name());
26 if (value && value->GetAsBoolean(&allow_dialogs)) { 26 if (value && value->GetAsBoolean(&allow_dialogs)) {
27 prefs->SetValue(prefs::kAllowFileSelectionDialogs, 27 prefs->SetBoolean(prefs::kAllowFileSelectionDialogs, allow_dialogs);
28 base::Value::CreateBooleanValue(allow_dialogs));
29 // Disallow selecting the download location if file dialogs are disabled. 28 // Disallow selecting the download location if file dialogs are disabled.
30 if (!allow_dialogs) { 29 if (!allow_dialogs)
31 prefs->SetValue(prefs::kPromptForDownload, 30 prefs->SetBoolean(prefs::kPromptForDownload, false);
32 base::Value::CreateBooleanValue(false));
33 }
34 } 31 }
35 } 32 }
36 33
37 } // namespace policy 34 } // namespace policy
OLDNEW
« no previous file with comments | « chrome/browser/guest_view/web_view/web_view_permission_helper.cc ('k') | chrome/browser/prefs/command_line_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698