chrome/browser/extensions/api/web_view/web_view_internal_api.cc - Issue 399493002: Remove many instances of CreateBooleanValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_view/web_view_internal_api.cc

Issue 399493002: Remove many instances of CreateBooleanValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/web_view/web_view_internal_api.cc

diff --git a/chrome/browser/extensions/api/web_view/web_view_internal_api.cc b/chrome/browser/extensions/api/web_view/web_view_internal_api.cc

index 13e187f7e2cbe0f071c685e85ffc651ef42da8d8..09d53e1c7f81d8ec075e3c18200ee4b04b06acd3 100644

--- a/chrome/browser/extensions/api/web_view/web_view_internal_api.cc

+++ b/chrome/browser/extensions/api/web_view/web_view_internal_api.cc

@@ -535,7 +535,7 @@ bool WebViewInternalSetPermissionFunction::RunAsyncSafe(WebViewGuest* guest) {

EXTENSION_FUNCTION_VALIDATE(

result != WebViewPermissionHelper::SET_PERMISSION_INVALID);

- SetResult(base::Value::CreateBooleanValue(

+ SetResult(new base::FundamentalValue(

result == WebViewPermissionHelper::SET_PERMISSION_ALLOWED));

SendResponse(true);

return true;