Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 395813002: Resolve light-source position/direction when updated (Closed)

Created:
6 years, 5 months ago by fs
Modified:
6 years, 5 months ago
CC:
blink-reviews, shans, fs, kouhei+svg_chromium.org, rwlbuis, jamesr, krit, danakj, dstockwell, Timothy Loh, Rik, pdr., Eric Willigers, Steve Block, rjwright, jbroman, gyuyoung.kim_webkit.org, darktears, blink-reviews-animation_chromium.org, Mike Lawther (Google), ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Project:
blink
Visibility:
Public.

Description

Resolve light-source position/direction when updated When 'x'/'y'/'z' on fePointLight/feSpotLight, or 'pointsAtX'/'pointsAtY'/'pointsAtZ' on feSpotLight is mutated (animated, changed through the DOM) and filter primitive units is 'objectBoundingBox', the new coordinate needs to be resolved against the filter's bounding-box. Also simplify getting these position/direction attributes of a light-source element by adding new methods on SVGFELightElement. BUG=393907 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -105 lines) Patch
A LayoutTests/svg/filters/fePointLight-primitiveUnits-objectBoundingBox-animated.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/svg/filters/fePointLight-primitiveUnits-objectBoundingBox-animated-expected.html View 1 chunk +2 lines, -1 line 0 comments Download
A LayoutTests/svg/filters/fePointLight-primitiveUnits-objectBoundingBox-mutation.html View 1 chunk +28 lines, -0 lines 0 comments Download
A + LayoutTests/svg/filters/fePointLight-primitiveUnits-objectBoundingBox-mutation-expected.html View 1 chunk +2 lines, -1 line 0 comments Download
A LayoutTests/svg/filters/feSpotLight-primitiveUnits-objectBoundingBox-animated.html View 1 chunk +25 lines, -0 lines 0 comments Download
A + LayoutTests/svg/filters/feSpotLight-primitiveUnits-objectBoundingBox-animated-expected.html View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/svg/SVGFEDiffuseLightingElement.cpp View 1 chunk +5 lines, -12 lines 0 comments Download
M Source/core/svg/SVGFELightElement.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFELightElement.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/svg/SVGFEPointLightElement.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/svg/SVGFESpecularLightingElement.cpp View 1 chunk +5 lines, -12 lines 0 comments Download
M Source/core/svg/SVGFESpotLightElement.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M Source/platform/graphics/filters/LightSource.h View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/platform/graphics/filters/PointLightSource.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/platform/graphics/filters/PointLightSource.cpp View 1 chunk +3 lines, -19 lines 0 comments Download
M Source/platform/graphics/filters/SpotLightSource.h View 1 chunk +2 lines, -6 lines 0 comments Download
M Source/platform/graphics/filters/SpotLightSource.cpp View 1 chunk +6 lines, -38 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fs
6 years, 5 months ago (2014-07-15 11:14:51 UTC) #1
kouhei (in TOK)
non-owner lgtm
6 years, 5 months ago (2014-07-15 11:30:38 UTC) #2
Stephen White
On 2014/07/15 11:30:38, kouhei wrote: > non-owner lgtm LGTM. Thanks for the quick fix!
6 years, 5 months ago (2014-07-15 12:11:12 UTC) #3
fs
The CQ bit was checked by fs@opera.com
6 years, 5 months ago (2014-07-15 12:17:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/395813002/1
6 years, 5 months ago (2014-07-15 12:18:03 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-15 12:38:34 UTC) #6
Message was sent while issue was closed.
Change committed as 178167

Powered by Google App Engine
This is Rietveld 408576698