Chromium Code Reviews Chromium Code Reviews
Issue
38063003:
Improve TypeError messages from failed array conversions. (Closed)
DescriptionImprove TypeError messages from failed array conversions.
Should the conversion of a value into a native array fail due to it
not having a sequence type, throw the expected TypeError but with a
message that better explains what failed.
Address this by extending the two v8 bindings helpers
WebCore::toNativeArray() and WebCore::toRefPtrNativeArray() with an
extra argument to indicate either the property name that's being
converted to an array, or its argument index position (1-indexed.)
(Or 0, if it is a setter with an array/sequence type.) In the case of
toRefPtrNativeArray(), either a property name or an argument index
might supplied; toNativeArray() only needs to support the argument
indexed form.
The code generator has been extended to supply the extra argument when
calling upon these two array conversion helpers.
So, if the array conversion fails due to the value not being array (or
array-like), the TypeError's message is now generated by a pair of
ExceptionMessages helper methods:
static String notASequenceTypeArgumentOrValue(int argumentIndexOrValue);
static String notASequenceTypeProperty(const String& propertyName);
which handles the argument/setter value and property case,
respectively. The output will be of the form
{X} is not an array, nor does it have indexed properties.
where X is one of
"'{ThePropertyName}' property"
"Value"
"Argument {First,Second,Third,<N>th}"
R=
BUG=308730
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160593
Patch Set 1 #
Total comments: 11
Patch Set 2 : Improve TypeError messages from failed array conversions. #
Total comments: 2
Patch Set 3 : Improve TypeError messages from failed array conversions. #Messages
Total messages: 8 (0 generated)
|
