Source/bindings/v8/ExceptionMessages.h - Issue 38063003: Improve TypeError messages from failed array conversions.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/v8/ExceptionMessages.h

Issue 38063003: Improve TypeError messages from failed array conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve TypeError messages from failed array conversions. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2013 Google Inc. All rights reserved.	2 * Copyright (C) 2013 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 25 matching lines...) Expand all Loading...
36 namespace WebCore {	36 namespace WebCore {

37	37

38 class ExceptionMessages {	38 class ExceptionMessages {

39 public:	39 public:

40 static String failedToConstruct(const String& type, const String& detail = S tring());	40 static String failedToConstruct(const String& type, const String& detail = S tring());

41 static String failedToExecute(const String& method, const String& type, cons t String& detail = String());	41 static String failedToExecute(const String& method, const String& type, cons t String& detail = String());

42 static String failedToGet(const String& property, const String& type, const String& detail);	42 static String failedToGet(const String& property, const String& type, const String& detail);

43 static String failedToSet(const String& property, const String& type, const String& detail);	43 static String failedToSet(const String& property, const String& type, const String& detail);

44 static String failedToDelete(const String& property, const String& type, con st String& detail);	44 static String failedToDelete(const String& property, const String& type, con st String& detail);

45	45

46 static String notASequenceType(const String& argument);	46 // If > 0, the argument index that failed type check (1-indexed.)

	47 // If <= 0, a (non-argument) value failed the same check.

	48 static String notASequenceTypeArgumentOrValue(int argumentIndexOrValue);

	49 static String notASequenceTypeProperty(const String& propertyName);

	50

47 static String notEnoughArguments(unsigned expected, unsigned providedleastNu mMandatoryParams);	51 static String notEnoughArguments(unsigned expected, unsigned providedleastNu mMandatoryParams);

48 };	52 };

49	53

50 } // namespace WebCore	54 } // namespace WebCore

51	55

52 #endif // ExceptionMessages_h	56 #endif // ExceptionMessages_h

OLD	NEW

« no previous file with comments | « Source/bindings/v8/Dictionary.cpp ('k') | Source/bindings/v8/ExceptionMessages.cpp » ('j') | no next file with comments »