Source/bindings/v8/V8Utilities.h - Issue 38063003: Improve TypeError messages from failed array conversions.

Side by Side Diff: Source/bindings/v8/V8Utilities.h

Issue 38063003: Improve TypeError messages from failed array conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/bindings/v8/V8Binding.h ('K') | « Source/bindings/v8/V8Binding.h ('k') | Source/bindings/v8/V8Utilities.cpp » ('j') | Source/bindings/v8/custom/V8MessageEventCustom.cpp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 45 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
56 typedef WTF::Vector<RefPtr<MessagePort>, 1> MessagePortArray;	56 typedef WTF::Vector<RefPtr<MessagePort>, 1> MessagePortArray;

57 typedef WTF::Vector<RefPtr<ArrayBuffer>, 1> ArrayBufferArray;	57 typedef WTF::Vector<RefPtr<ArrayBuffer>, 1> ArrayBufferArray;

58	58

59 // Helper function which pulls the values out of a JS sequence and into a Me ssagePortArray.	59 // Helper function which pulls the values out of a JS sequence and into a Me ssagePortArray.

60 // Also validates the elements per sections 4.1.13 and 4.1.15 of the WebIDL spec and section 8.3.3	60 // Also validates the elements per sections 4.1.13 and 4.1.15 of the WebIDL spec and section 8.3.3

61 // of the HTML5 spec and generates exceptions as appropriate. If the supplie d argument's type isn't	61 // of the HTML5 spec and generates exceptions as appropriate. If the supplie d argument's type isn't

62 // a JS sequence, a type error is signalled by setting 'notASequence' to tru e -- the caller	62 // a JS sequence, a type error is signalled by setting 'notASequence' to tru e -- the caller

63 // then being responsible for generating a TypeError having a message that f its the context.	63 // then being responsible for generating a TypeError having a message that f its the context.

64 // Returns true if the array was filled, or false if the passed value was no t of an appropriate type.	64 // Returns true if the array was filled, or false if the passed value was no t of an appropriate type.

65 bool extractTransferables(v8::Local<v8::Value>, MessagePortArray&, ArrayBuff erArray&, bool& notASequence, v8::Isolate*);	65 bool extractTransferables(v8::Local<v8::Value>, MessagePortArray&, ArrayBuff erArray&, bool& notASequence, v8::Isolate*);

66 bool getMessagePortArray(v8::Local<v8::Value>, MessagePortArray&, v8::Isolat e*);	66 bool getMessagePortArray(v8::Local<v8::Value>, const String&, MessagePortArr ay&, v8::Isolate*);
	Mike West 2013/10/24 07:08:54 Please add a name here. 'String&' isn't descriptiv Please add a name here. 'String&' isn't descriptive enough for a .h file.
	67 bool getMessagePortArray(v8::Local<v8::Value>, int, MessagePortArray&, v8::I solate*);

67	68

68 } // namespace WebCore	69 } // namespace WebCore

69	70

70 #endif // V8Utilities_h	71 #endif // V8Utilities_h

OLD	NEW