Source/bindings/v8/Dictionary.cpp - Issue 38063003: Improve TypeError messages from failed array conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/Dictionary.cpp

Issue 38063003: Improve TypeError messages from failed array conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve TypeError messages from failed array conversions. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/Dictionary.cpp

diff --git a/Source/bindings/v8/Dictionary.cpp b/Source/bindings/v8/Dictionary.cpp

index 72776e6f81701f8729d60bb92bc6414fb3855ade..2cf9aa4bdce4f5a231c59a151b4c0f795df14772 100644

--- a/Source/bindings/v8/Dictionary.cpp

+++ b/Source/bindings/v8/Dictionary.cpp

@@ -288,7 +288,7 @@ bool Dictionary::get(const String& key, MessagePortArray& value) const

ASSERT(m_isolate);

ASSERT(m_isolate == v8::Isolate::GetCurrent());

- return getMessagePortArray(v8Value, value, m_isolate);

+ return getMessagePortArray(v8Value, key, value, m_isolate);

}

bool Dictionary::get(const String& key, HashSet<AtomicString>& value) const

« no previous file with comments | « Source/bindings/tests/results/V8TestTypedefs.cpp ('k') | Source/bindings/v8/ExceptionMessages.h » ('j') | no next file with comments »