Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: Source/bindings/tests/results/V8TestTypedefs.cpp

Issue 38063003: Improve TypeError messages from failed array conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve TypeError messages from failed array conversions. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | Source/bindings/v8/Dictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestTypedefs.cpp
diff --git a/Source/bindings/tests/results/V8TestTypedefs.cpp b/Source/bindings/tests/results/V8TestTypedefs.cpp
index 3c916ca6a1736870cc3dfc7374f68fdfe68b45d0..6ab28bf31a55d517c2cfb280fde1ab1c84649098 100644
--- a/Source/bindings/tests/results/V8TestTypedefs.cpp
+++ b/Source/bindings/tests/results/V8TestTypedefs.cpp
@@ -269,7 +269,7 @@ static void funcMethod(const v8::FunctionCallbackInfo<v8::Value>& args)
return;
}
- V8TRYCATCH_VOID(Vector<int>, x, toNativeArray<int>(args[0], args.GetIsolate()));
+ V8TRYCATCH_VOID(Vector<int>, x, toNativeArray<int>(args[0], 1, args.GetIsolate()));
imp->func(x);
return;
@@ -323,7 +323,7 @@ static void methodWithSequenceArgMethod(const v8::FunctionCallbackInfo<v8::Value
return;
}
TestTypedefs* imp = V8TestTypedefs::toNative(args.Holder());
- V8TRYCATCH_VOID(Vector<RefPtr<SerializedScriptValue> >, sequenceArg, (toRefPtrNativeArray<SerializedScriptValue, V8SerializedScriptValue>(args[0], args.GetIsolate())));
+ V8TRYCATCH_VOID(Vector<RefPtr<SerializedScriptValue> >, sequenceArg, (toRefPtrNativeArray<SerializedScriptValue, V8SerializedScriptValue>(args[0], 1, args.GetIsolate())));
v8SetReturnValue(args, static_cast<double>(imp->methodWithSequenceArg(sequenceArg)));
return;
}
@@ -343,7 +343,7 @@ static void nullableArrayArgMethod(const v8::FunctionCallbackInfo<v8::Value>& ar
}
TestTypedefs* imp = V8TestTypedefs::toNative(args.Holder());
bool arrayArgIsNull = args[0]->IsNull();
- V8TRYCATCH_VOID(Vector<String>, arrayArg, toNativeArray<String>(args[0], args.GetIsolate()));
+ V8TRYCATCH_VOID(Vector<String>, arrayArg, toNativeArray<String>(args[0], 1, args.GetIsolate()));
imp->nullableArrayArg(arrayArgIsNull ? 0 : &arrayArg);
return;
@@ -410,7 +410,7 @@ static void stringArrayFunctionMethod(const v8::FunctionCallbackInfo<v8::Value>&
}
TestTypedefs* imp = V8TestTypedefs::toNative(args.Holder());
ExceptionState es(args.GetIsolate());
- V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0], args.GetIsolate()));
+ V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0], 1, args.GetIsolate()));
Vector<String> result = imp->stringArrayFunction(values, es);
if (es.throwIfNeeded())
return;
@@ -433,7 +433,7 @@ static void stringArrayFunction2Method(const v8::FunctionCallbackInfo<v8::Value>
}
TestTypedefs* imp = V8TestTypedefs::toNative(args.Holder());
ExceptionState es(args.GetIsolate());
- V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0], args.GetIsolate()));
+ V8TRYCATCH_VOID(Vector<String>, values, toNativeArray<String>(args[0], 1, args.GetIsolate()));
Vector<String> result = imp->stringArrayFunction2(values, es);
if (es.throwIfNeeded())
return;
« no previous file with comments | « Source/bindings/tests/results/V8TestObjectPython.cpp ('k') | Source/bindings/v8/Dictionary.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698