Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: LayoutTests/fast/events/constructors/message-event-constructor-expected.txt

Issue 38063003: Improve TypeError messages from failed array conversions. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve TypeError messages from failed array conversions. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/events/constructors/message-event-constructor-expected.txt
diff --git a/LayoutTests/fast/events/constructors/message-event-constructor-expected.txt b/LayoutTests/fast/events/constructors/message-event-constructor-expected.txt
index 0678b46567254413feb7256d3c9d033e38b8ec0f..4e74e8f9b04752fbfb4b41fee45efa4568d5febf 100644
--- a/LayoutTests/fast/events/constructors/message-event-constructor-expected.txt
+++ b/LayoutTests/fast/events/constructors/message-event-constructor-expected.txt
@@ -83,18 +83,18 @@ PASS new MessageEvent('eventType', { ports: [] }).ports is []
PASS new MessageEvent('eventType', { ports: undefined }).ports is []
PASS new MessageEvent('eventType', { ports: null }).ports is []
PASS new MessageEvent('eventType', { ports: [1, 2, 3] }).ports[2] threw exception TypeError: Invalid Array element type.
-PASS new MessageEvent('eventType', { ports: test_object }).ports threw exception TypeError: Type error.
-PASS new MessageEvent('eventType', { ports: document }).ports threw exception TypeError: Type error.
-PASS new MessageEvent('eventType', { ports: false }).ports threw exception TypeError: Type error.
-PASS new MessageEvent('eventType', { ports: true }).ports threw exception TypeError: Type error.
-PASS new MessageEvent('eventType', { ports: '' }).ports threw exception TypeError: Type error.
-PASS new MessageEvent('eventType', { ports: 'chocolate' }).ports threw exception TypeError: Type error.
-PASS new MessageEvent('eventType', { ports: 12345 }).ports threw exception TypeError: Type error.
-PASS new MessageEvent('eventType', { ports: 18446744073709551615 }).ports threw exception TypeError: Type error.
-PASS new MessageEvent('eventType', { ports: NaN }).ports threw exception TypeError: Type error.
-PASS new MessageEvent('eventType', { get ports() { return 123; } }).ports threw exception TypeError: Type error.
+PASS new MessageEvent('eventType', { ports: test_object }).ports threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
+PASS new MessageEvent('eventType', { ports: document }).ports threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
+PASS new MessageEvent('eventType', { ports: false }).ports threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
+PASS new MessageEvent('eventType', { ports: true }).ports threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
+PASS new MessageEvent('eventType', { ports: '' }).ports threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
+PASS new MessageEvent('eventType', { ports: 'chocolate' }).ports threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
+PASS new MessageEvent('eventType', { ports: 12345 }).ports threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
+PASS new MessageEvent('eventType', { ports: 18446744073709551615 }).ports threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
+PASS new MessageEvent('eventType', { ports: NaN }).ports threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
+PASS new MessageEvent('eventType', { get ports() { return 123; } }).ports threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
PASS new MessageEvent('eventType', { get ports() { throw 'MessageEvent Error'; } }) threw exception MessageEvent Error.
-PASS new MessageEvent('eventType', { ports: {valueOf: function () { return [channel.port1, channel.port2, channel.port2]; } } }).ports[0] threw exception TypeError: Type error.
+PASS new MessageEvent('eventType', { ports: {valueOf: function () { return [channel.port1, channel.port2, channel.port2]; } } }).ports[0] threw exception TypeError: 'ports' property is neither an array, nor does it have indexed properties..
PASS new MessageEvent('eventType', { bubbles: true, cancelable: true, data: test_object, origin: 'wonderful', lastEventId: 'excellent', source: window, ports: [channel.port1, channel.port2, channel2.port1] }).bubbles is true
PASS new MessageEvent('eventType', { bubbles: true, cancelable: true, data: test_object, origin: 'wonderful', lastEventId: 'excellent', source: window, ports: [channel.port1, channel.port2, channel2.port1] }).cancelable is true
PASS new MessageEvent('eventType', { bubbles: true, cancelable: true, data: test_object, origin: 'wonderful', lastEventId: 'excellent', source: window, ports: [channel.port1, channel.port2, channel2.port1] }).data is test_object
« no previous file with comments | « LayoutTests/fast/canvas/canvas-lineDash-input-sequence-expected.txt ('k') | LayoutTests/fast/events/init-message-event.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698