Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*.

Make GrDrawState and GrPaint take GrEffect* instead of GrEffectRef*.

Make Sk-effect virtuals produce GrEffect* rather than GrEffectRef*

Make GrEffectRef a typedef for GrEffect.

Committed: https://skia.googlesource.com/skia/+/2011fe9cdfa63b83489a146cea6a724cede352c8

Committed: https://skia.googlesource.com/skia/+/97b9ab72cd5ee0cba4692082737266376425f27c

[bsalomon, 2014-07-07 19:51:32]

https://codereview.chromium.org/377503004/diff/1/include/gpu/GrEffect.h
File include/gpu/GrEffect.h (right):

https://codereview.chromium.org/377503004/diff/1/include/gpu/GrEffect.h#newco...
include/gpu/GrEffect.h:174: static GrEffect* CreateEffectRef(GrEffect* effect) {
This and AutoEffectRef will be removed in a follow-on CL.

[robertphillips, 2014-07-07 20:03:51]

lgtm + nits

https://codereview.chromium.org/377503004/diff/1/include/effects/SkMagnifierI...
File include/effects/SkMagnifierImageFilter.h (right):

https://codereview.chromium.org/377503004/diff/1/include/effects/SkMagnifierI...
include/effects/SkMagnifierImageFilter.h:30: #if SK_SUPPORT_GPU
overlength ?

https://codereview.chromium.org/377503004/diff/1/include/gpu/GrEffect.h
File include/gpu/GrEffect.h (right):

https://codereview.chromium.org/377503004/diff/1/include/gpu/GrEffect.h#newco...
include/gpu/GrEffect.h:251: static GrEffect* NAME
SkNEW_PLACEMENT_ARGS(g_##NAME##_Storage.get(), EFFECT_CLASS, ARGS);         \
Line the '\' up with the others ?

https://codereview.chromium.org/377503004/diff/1/include/gpu/GrEffectStage.h
File include/gpu/GrEffectStage.h (right):

https://codereview.chromium.org/377503004/diff/1/include/gpu/GrEffectStage.h#...
include/gpu/GrEffectStage.h:136: SkMatrix                           
fCoordChangeMatrix;
Line this guy up ?

[bsalomon, 2014-07-07 21:13:52]

https://codereview.chromium.org/377503004/diff/1/include/effects/SkMagnifierI...
File include/effects/SkMagnifierImageFilter.h (right):

https://codereview.chromium.org/377503004/diff/1/include/effects/SkMagnifierI...
include/effects/SkMagnifierImageFilter.h:30: #if SK_SUPPORT_GPU
On 2014/07/07 20:03:51, robertphillips wrote:
> overlength ?

Done.

https://codereview.chromium.org/377503004/diff/1/include/gpu/GrEffect.h
File include/gpu/GrEffect.h (right):

https://codereview.chromium.org/377503004/diff/1/include/gpu/GrEffect.h#newco...
include/gpu/GrEffect.h:251: static GrEffect* NAME
SkNEW_PLACEMENT_ARGS(g_##NAME##_Storage.get(), EFFECT_CLASS, ARGS);         \
On 2014/07/07 20:03:51, robertphillips wrote:
> Line the '\' up with the others ?

Removed the \' as it is now on the last line of the macro.

https://codereview.chromium.org/377503004/diff/1/include/gpu/GrEffectStage.h
File include/gpu/GrEffectStage.h (right):

https://codereview.chromium.org/377503004/diff/1/include/gpu/GrEffectStage.h#...
include/gpu/GrEffectStage.h:136: SkMatrix                           
fCoordChangeMatrix;
On 2014/07/07 20:03:51, robertphillips wrote:
> Line this guy up ?

Done.

[bsalomon, 2014-07-07 21:13:56]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-07-07 21:15:07]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/377503004/20001

[commit-bot: I haz the power, 2014-07-07 21:34:23]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[commit-bot: I haz the power, 2014-07-07 21:36:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-07 21:36:36]

Try jobs failed on following builders:
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.skia
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[bsalomon, 2014-07-07 21:42:37]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-07-07 21:43:22]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/377503004/40001

[commit-bot: I haz the power, 2014-07-07 22:11:35]

Change committed as 2011fe9cdfa63b83489a146cea6a724cede352c8

[reed1, 2014-07-07 22:16:40]

A revert of this CL has been created in
https://codereview.chromium.org/372053003/ by reed@google.com.

The reason for reverting is: broke linux builders
.

[sugoi1, 2014-07-08 02:28:30]

On 2014/07/07 22:16:40, reed1 wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/372053003/ by mailto:reed@google.com.
> 
> The reason for reverting is: broke linux builders
> .

Unfortunately, this cl was committed right after the changes in
https://codereview.chromium.org/378503006 landed and I think the new class added
in that cl needs to be updated to reflect the changes made in this cl. I wasn't
understanding the error messages I was getting from the buildbots until I saw
this cl.

[bsalomon, 2014-07-08 13:21:32]

On 2014/07/08 02:28:30, sugoi1 wrote:
> On 2014/07/07 22:16:40, reed1 wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/372053003/ by mailto:reed@google.com.
> > 
> > The reason for reverting is: broke linux builders
> > .
> 
> Unfortunately, this cl was committed right after the changes in
> https://codereview.chromium.org/378503006 landed and I think the new class
added
> in that cl needs to be updated to reflect the changes made in this cl. I
wasn't
> understanding the error messages I was getting from the buildbots until I saw
> this cl.

Yup, just a case of bad timing by the CQ in landing changes. I made the very
minor updates that need to be done to the new YUV effect to reland this.

[bsalomon, 2014-07-08 13:21:39]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-07-08 13:22:11]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/377503004/60001

[commit-bot: I haz the power, 2014-07-08 13:52:41]

Change committed as 97b9ab72cd5ee0cba4692082737266376425f27c