YUV to RGB converter

YUV to RGB converter

This is a first piece of the GPU YUV decoder, which is the actual effect that performs the conversion. For now, it simply applies the conversion matrix, since it is all I need. I may add modes if different matrices need to be applied or if I add color profile support here.

I'll try to keep these cls short and easy to review, but there should be a few of them coming once this one is in.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/24dcac2140a7cca111c7f1bd44b44541644887a3

[Stephen White, 2014-07-07 17:57:06]

LGTM, but will leave for others.

https://codereview.chromium.org/378503006/diff/1/src/gpu/effects/GrYUVtoRGBEf...
File src/gpu/effects/GrYUVtoRGBEffect.cpp (right):

https://codereview.chromium.org/378503006/diff/1/src/gpu/effects/GrYUVtoRGBEf...
src/gpu/effects/GrYUVtoRGBEffect.cpp:15: class YUVtoRGBEffect : public GrEffect
{
Since this doesn't have the Sk or Gr prefix, perhaps it should be in the unnamed
namespace?

[bsalomon, 2014-07-07 17:57:12]

It's possible to add a GM that directly tests an effect. See
gm/texturedomaineffect.cpp.

https://codereview.chromium.org/378503006/diff/1/src/gpu/effects/GrYUVtoRGBEf...
File src/gpu/effects/GrYUVtoRGBEffect.cpp (right):

https://codereview.chromium.org/378503006/diff/1/src/gpu/effects/GrYUVtoRGBEf...
src/gpu/effects/GrYUVtoRGBEffect.cpp:31: *validFlags = kA_GrColorComponentFlag;
You have to assign a value to the "color" param's alpha to make use of this
flag. From the look of your effect impl it should be set to 0xff.

[sugoi1, 2014-07-07 20:52:36]

https://codereview.chromium.org/378503006/diff/1/src/gpu/effects/GrYUVtoRGBEf...
File src/gpu/effects/GrYUVtoRGBEffect.cpp (right):

https://codereview.chromium.org/378503006/diff/1/src/gpu/effects/GrYUVtoRGBEf...
src/gpu/effects/GrYUVtoRGBEffect.cpp:15: class YUVtoRGBEffect : public GrEffect
{
On 2014/07/07 17:57:06, Stephen White wrote:
> Since this doesn't have the Sk or Gr prefix, perhaps it should be in the
unnamed
> namespace?

Done.

https://codereview.chromium.org/378503006/diff/1/src/gpu/effects/GrYUVtoRGBEf...
src/gpu/effects/GrYUVtoRGBEffect.cpp:31: *validFlags = kA_GrColorComponentFlag;
On 2014/07/07 17:57:11, bsalomon wrote:
> You have to assign a value to the "color" param's alpha to make use of this
> flag. From the look of your effect impl it should be set to 0xff.
> 

Done.

[bsalomon, 2014-07-07 21:07:48]

lgtm

[sugoi1, 2014-07-07 21:52:29]

The CQ bit was checked by sugoi@chromium.org

[commit-bot: I haz the power, 2014-07-07 21:53:20]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/378503006/20001

[commit-bot: I haz the power, 2014-07-07 22:09:57]

Change committed as 24dcac2140a7cca111c7f1bd44b44541644887a3