Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 37733003: Make GetRootWindow() return a Window instead of a RootWindow. (Closed)

Created:
7 years, 2 months ago by Ben Goodger (Google)
Modified:
7 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+aura_chromium.org, kalyank
Visibility:
Public.

Description

Make GetRootWindow() return a Window instead of a RootWindow. Also adds a typedef from RootWindow to WindowEventDispatcher, the eventual name of this type. Adds a GetDispatcher() method that crawls up to the root Window and returns the WindowEventDispatcher. R=sky@chromium.org http://crbug.com/308843 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231077

Patch Set 1 #

Patch Set 2 : progress 10/23/2013-11:29PM #

Patch Set 3 : . #

Patch Set 4 : First cut for review/trybots #

Total comments: 1

Patch Set 5 : NULL dispatcher #

Patch Set 6 : trybot 1 #

Patch Set 7 : rebase #

Patch Set 8 : cros build #

Patch Set 9 : linux_aura #

Patch Set 10 : RootWindow::GetRootWindow should return Window. #

Patch Set 11 : rebase #

Patch Set 12 : rebase #

Patch Set 13 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+890 lines, -853 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 2 3 2 chunks +14 lines, -12 lines 0 comments Download
M ash/accelerators/exit_warning_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/accelerators/nested_dispatcher_controller_unittest.cc View 1 2 3 4 5 6 7 4 chunks +8 lines, -6 lines 0 comments Download
M ash/autoclick/autoclick_controller.cc View 1 2 3 11 2 chunks +6 lines, -4 lines 0 comments Download
M ash/autoclick/autoclick_unittest.cc View 1 2 3 4 5 6 7 11 1 chunk +1 line, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_controller_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/dip_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/display_controller.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_controller.cc View 1 2 3 4 5 6 7 7 chunks +16 lines, -14 lines 0 comments Download
M ash/display/display_controller_unittest.cc View 1 2 3 4 5 6 7 9 chunks +30 lines, -28 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M ash/display/mirror_window_controller_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.h View 1 2 3 4 chunks +4 lines, -3 lines 0 comments Download
M ash/display/mouse_cursor_event_filter.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M ash/display/root_window_transformers.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/root_window_transformers.cc View 1 2 3 6 chunks +6 lines, -6 lines 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/display/screen_position_controller.cc View 1 2 3 4 5 6 7 9 chunks +16 lines, -13 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M ash/drag_drop/drag_drop_tracker.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/focus_cycler_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_item_delegate.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 2 3 9 chunks +9 lines, -9 lines 0 comments Download
M ash/magnifier/magnification_controller_unittest.cc View 1 2 3 4 5 6 7 2 chunks +3 lines, -3 lines 0 comments Download
M ash/magnifier/partial_magnification_controller.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/magnifier/partial_magnification_controller.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ash/root_window_controller.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 1 2 3 11 5 chunks +5 lines, -5 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +5 lines, -5 lines 0 comments Download
M ash/root_window_settings.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M ash/root_window_settings.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ash/scoped_target_root_window.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/scoped_target_root_window.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/screensaver/screensaver_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/app_list_shelf_item_delegate.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/app_list_shelf_item_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_alignment_menu.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_alignment_menu.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_layout_manager_observer.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_tooltip_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_tooltip_manager_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/shelf/shelf_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_widget_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shell.h View 1 2 3 4 5 6 7 8 9 10 11 6 chunks +17 lines, -17 lines 0 comments Download
M ash/shell.cc View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +15 lines, -14 lines 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/context_menu.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell/context_menu.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shell/window_watcher_launcher_item_delegate.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher_launcher_item_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/window_watcher_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M ash/shell_observer.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M ash/shell_unittest.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M ash/system/tray/tray_background_view.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/tray/tray_event_filter.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M ash/test/ash_test_base.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M ash/test/ash_test_helper.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/test/test_launcher_item_delegate.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_launcher_item_delegate.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M ash/test/ui_controls_factory_ash.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M ash/touch/touch_observer_hud.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M ash/wm/app_list_controller.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/ash_focus_rules.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/base_layout_manager.h View 1 2 3 4 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/base_layout_manager.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M ash/wm/caption_buttons/frame_maximize_button_unittest.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/coordinate_conversion.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/coordinate_conversion.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_window_resizer.cc View 1 2 3 4 5 6 11 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/event_client_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/gestures/long_press_affordance_handler.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/header_painter.h View 1 2 3 4 chunks +3 lines, -4 lines 0 comments Download
M ash/wm/header_painter.cc View 1 2 3 5 chunks +7 lines, -8 lines 0 comments Download
M ash/wm/header_painter_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/lock_state_controller.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/lock_state_controller_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/mru_window_tracker.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/overview/scoped_transform_overview_window.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M ash/wm/overview/scoped_transform_overview_window.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/overview/window_overview.h View 1 2 3 5 chunks +5 lines, -9 lines 0 comments Download
M ash/wm/overview/window_overview.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 1 2 3 11 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector_item.h View 1 2 3 5 chunks +4 lines, -5 lines 0 comments Download
M ash/wm/overview/window_selector_item.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_panels.h View 1 2 3 2 chunks +2 lines, -7 lines 0 comments Download
M ash/wm/overview/window_selector_panels.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 2 3 4 chunks +7 lines, -6 lines 0 comments Download
M ash/wm/overview/window_selector_window.h View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M ash/wm/overview/window_selector_window.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_layout_manager.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/panels/panel_layout_manager.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/panels/panel_layout_manager_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/panels/panel_window_resizer_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/partial_screenshot_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/screen_dimmer_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/session_state_animator.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/stacking_controller.h View 1 2 3 2 chunks +1 line, -6 lines 0 comments Download
M ash/wm/stacking_controller.cc View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M ash/wm/sticky_keys.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 2 3 4 5 6 7 11 12 10 chunks +12 lines, -10 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_cycle_controller_unittest.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 2 3 16 chunks +49 lines, -41 lines 0 comments Download
M ash/wm/window_positioner.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/window_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/phantom_window_controller.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M ash/wm/workspace/phantom_window_controller.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 2 3 4 5 6 11 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 3 4 5 6 7 10 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/display/overscan_calibrator.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/drag_download_item_views.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input/input.cc View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/first_run/try_chrome_dialog_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/pepper/pepper_flash_drm_host.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 1 2 3 2 chunks +8 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.h View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 2 3 4 5 6 7 8 9 10 11 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.h View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/launcher/launcher_context_menu.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/shell_window_launcher_item_controller.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/screenshot_taker.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/aura/tabs/dock_info_aurax11.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/apps/native_app_window_views.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/certificate_viewer_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/app_non_client_frame_view_ash_browsertest.cc View 1 2 3 4 5 6 7 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/tabs/dock_info_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc View 1 2 3 4 5 6 7 11 12 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 2 3 4 5 6 7 11 12 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/interactive_test_utils_win.cc View 1 2 3 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 5 6 7 8 9 10 11 12 37 chunks +63 lines, -62 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 3 11 12 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/touch_smooth_scroll_gesture_aura.cc View 1 11 12 1 chunk +4 lines, -5 lines 0 comments Download
M content/browser/web_contents/touch_editable_impl_aura_browsertest.cc View 1 2 3 4 5 6 7 11 12 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 11 12 5 chunks +7 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 1 2 3 11 12 5 chunks +7 lines, -7 lines 0 comments Download
M content/shell/browser/shell_views.cc View 1 2 3 11 12 1 chunk +1 line, -1 line 0 comments Download
M printing/printing_context_win.cc View 1 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/client/default_capture_client.cc View 1 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/client/focus_client.cc View 1 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/client/window_tree_client.cc View 1 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M ui/aura/root_window.h View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/root_window.cc View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +11 lines, -8 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 1 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/event_generator.h View 1 2 3 4 5 6 11 12 2 chunks +3 lines, -3 lines 0 comments Download
M ui/aura/test/event_generator.cc View 1 2 3 4 5 6 11 12 5 chunks +6 lines, -6 lines 0 comments Download
M ui/aura/test/ui_controls_factory_aurawin.cc View 1 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/window.h View 1 11 12 3 chunks +18 lines, -4 lines 0 comments Download
M ui/aura/window.cc View 1 11 12 16 chunks +50 lines, -38 lines 0 comments Download
M ui/keyboard/keyboard_ui_handler.cc View 1 11 12 4 chunks +7 lines, -7 lines 0 comments Download
M ui/keyboard/keyboard_util.h View 1 2 3 11 12 3 chunks +5 lines, -6 lines 0 comments Download
M ui/keyboard/keyboard_util.cc View 1 2 3 4 5 6 7 8 9 10 11 12 7 chunks +15 lines, -14 lines 0 comments Download
M ui/shell_dialogs/select_file_dialog_win.cc View 1 11 12 2 chunks +2 lines, -2 lines 0 comments Download
M ui/snapshot/snapshot_aura.cc View 1 11 12 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/menu/display_change_listener_aura.cc View 1 2 3 11 12 2 chunks +3 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_controller_aura.cc View 1 11 12 5 chunks +7 lines, -7 lines 0 comments Download
M ui/views/corewm/capture_controller.h View 1 2 3 11 12 5 chunks +5 lines, -9 lines 0 comments Download
M ui/views/corewm/capture_controller.cc View 1 2 3 11 12 4 chunks +9 lines, -8 lines 0 comments Download
M ui/views/corewm/compound_event_filter.cc View 1 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/focus_controller_unittest.cc View 1 2 3 4 5 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/input_method_event_filter.h View 1 2 3 11 12 3 chunks +4 lines, -8 lines 0 comments Download
M ui/views/corewm/input_method_event_filter.cc View 1 11 12 5 chunks +7 lines, -7 lines 0 comments Download
M ui/views/corewm/tooltip_aura.cc View 1 11 12 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/corewm/tooltip_controller.cc View 1 11 12 2 chunks +1 line, -2 lines 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 2 3 4 5 6 7 8 11 12 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/drag_utils.cc View 1 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/views/event_utils_aura.cc View 1 11 12 2 chunks +4 lines, -3 lines 0 comments Download
M ui/views/test/ui_controls_factory_desktop_aurax11.cc View 1 2 3 4 5 6 7 8 11 12 6 chunks +15 lines, -15 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 1 2 3 4 5 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drop_target_win.cc View 1 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 3 11 12 2 chunks +8 lines, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_position_client.cc View 1 11 12 6 chunks +8 lines, -8 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_win.cc View 1 11 12 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_screen_x11.cc View 1 2 3 4 5 11 12 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_window_move_client.cc View 1 2 3 4 5 11 12 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 11 12 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/widget/tooltip_manager_aura.h View 1 11 12 2 chunks +1 line, -2 lines 0 comments Download
M ui/views/widget/tooltip_manager_aura.cc View 1 11 12 3 chunks +7 lines, -5 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 1 2 3 11 12 4 chunks +6 lines, -7 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 3 11 12 4 chunks +4 lines, -4 lines 0 comments Download
M ui/views/win/hwnd_util_aurawin.cc View 1 11 12 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ben Goodger (Google)
7 years, 2 months ago (2013-10-24 20:48:05 UTC) #1
Ben Goodger (Google)
There are probably many more places where we could use Window instead of RootWindow/WED, but ...
7 years, 2 months ago (2013-10-24 20:49:34 UTC) #2
sky
https://codereview.chromium.org/37733003/diff/80001/ui/aura/root_window.cc File ui/aura/root_window.cc (right): https://codereview.chromium.org/37733003/diff/80001/ui/aura/root_window.cc#newcode152 ui/aura/root_window.cc:152: set_dispatcher(this); You need to set this to NULL in ...
7 years, 2 months ago (2013-10-24 20:59:45 UTC) #3
sky
LGTM when set_dispatcher(NULL) added
7 years, 2 months ago (2013-10-24 21:02:08 UTC) #4
Ben Goodger (Google)
7 years, 1 month ago (2013-10-25 19:22:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #13 manually as r231077 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698