Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 369863002: Revert 281130 "Replace "external_install" boolean parameter with..." (Closed)

Created:
6 years, 5 months ago by Nikita (slow)
Modified:
6 years, 5 months ago
Reviewers:
rpaquay
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 281130 "Replace "external_install" boolean parameter with..." Reason for revert: Speculative revert, PlatformAppBrowserTest.Messaging test is broken: http://goo.gl/nYCK6a > Replace "external_install" boolean parameter with explicit enumeration in ExtensionUninstall method. > > The intent is to be able to address issues found in https://code.google.com/p/chromium/issues/detail?id=84556#c39 > > * This change should be a strict refactoring, and there should be no change of behavior wrt to extension uninstall behavior. > > * Identify a few specific reasons for extension uninstall and create enum values for them. > > * Run "git cl format" > > > BUG=84556 > TBR=sky@chromium.org for trivial changes under chrome/browser, except chrome/browser/extensions (already lgtm'ed). > > Review URL: https://codereview.chromium.org/284103002 TBR=rpaquay@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=281227

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -187 lines) Patch
M trunk/src/chrome/browser/apps/drive/drive_app_provider.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/apps/ephemeral_app_browsertest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/apps/ephemeral_app_service.cc View 1 chunk +1 line, -5 lines 0 comments Download
M trunk/src/chrome/browser/background/background_application_list_model_unittest.cc View 4 chunks +11 lines, -22 lines 0 comments Download
M trunk/src/chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/api/management/management_api.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_disabled_ui.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc View 3 chunks +9 lines, -18 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_service.h View 2 chunks +8 lines, -20 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_service.cc View 5 chunks +8 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_service_unittest.cc View 7 chunks +8 lines, -16 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_storage_monitor.cc View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/extension_sync_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/extensions/external_install_error.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/shared_module_service.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/extensions/shared_module_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/chrome/browser/policy/policy_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/search/hotword_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/sync/test/integration/sync_extension_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/themes/theme_service.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M trunk/src/chrome/browser/themes/theme_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/app_list/extension_app_model_builder_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/app_list/extension_uninstaller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/app_list/search/app_search_provider_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/browser_browsertest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/apps/app_shim_menu_controller_mac_browsertest.mm View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/cocoa/extensions/extension_action_context_menu_controller.mm View 1 chunk +2 lines, -5 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/src/chrome/browser/ui/views/extensions/bookmark_app_bubble_view.cc View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M trunk/src/chrome/browser/ui/webui/ntp/app_launcher_handler.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nikita (slow)
6 years, 5 months ago (2014-07-03 09:24:23 UTC) #1
Nikita (slow)
Committed patchset #1 manually as r281227 (tree was closed).
6 years, 5 months ago (2014-07-03 09:25:19 UTC) #2
Nikita (slow)
6 years, 5 months ago (2014-07-03 13:41:02 UTC) #3
Message was sent while issue was closed.
Ok so test is still failing (http://goo.gl/jfJxhL), I'm placing this commit
back.

Powered by Google App Engine
This is Rietveld 408576698