Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: trunk/src/chrome/browser/extensions/shared_module_service.cc

Issue 369863002: Revert 281130 "Replace "external_install" boolean parameter with..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/chrome/browser/extensions/external_install_error.cc ('k') | trunk/src/chrome/browser/extensions/shared_module_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/chrome/browser/extensions/shared_module_service.cc
===================================================================
--- trunk/src/chrome/browser/extensions/shared_module_service.cc (revision 281226)
+++ trunk/src/chrome/browser/extensions/shared_module_service.cc (working copy)
@@ -152,10 +152,9 @@
scoped_ptr<ExtensionSet> dependents =
GetDependentExtensions(imported_module);
if (dependents->is_empty()) {
- service->UninstallExtension(
- iter->extension_id,
- ExtensionService::UNINSTALL_REASON_ORPHANED_SHARED_MODULE,
- NULL); // Ignore error.
+ service->UninstallExtension(iter->extension_id,
+ true, // External uninstall.
+ NULL); // Ignore error.
}
}
}
« no previous file with comments | « trunk/src/chrome/browser/extensions/external_install_error.cc ('k') | trunk/src/chrome/browser/extensions/shared_module_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698