Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: trunk/src/chrome/browser/extensions/extension_message_bubble_controller_unittest.cc

Issue 369863002: Revert 281130 "Replace "external_install" boolean parameter with..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/strings/string_number_conversions.h" 6 #include "base/strings/string_number_conversions.h"
7 #include "base/strings/string_util.h" 7 #include "base/strings/string_util.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h" 10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h"
(...skipping 702 matching lines...) Expand 10 before | Expand all | Expand 10 after
713 // Only extension 2 should have become disabled. 713 // Only extension 2 should have become disabled.
714 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId1) != NULL); 714 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId1) != NULL);
715 EXPECT_TRUE(registry->disabled_extensions().GetByID(kId2) != NULL); 715 EXPECT_TRUE(registry->disabled_extensions().GetByID(kId2) != NULL);
716 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId3) != NULL); 716 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId3) != NULL);
717 // No extension should have been acknowledged (it got disabled). 717 // No extension should have been acknowledged (it got disabled).
718 EXPECT_FALSE(prefs->HasSettingsApiBubbleBeenAcknowledged(kId1)); 718 EXPECT_FALSE(prefs->HasSettingsApiBubbleBeenAcknowledged(kId1));
719 EXPECT_FALSE(prefs->HasSettingsApiBubbleBeenAcknowledged(kId2)); 719 EXPECT_FALSE(prefs->HasSettingsApiBubbleBeenAcknowledged(kId2));
720 EXPECT_FALSE(prefs->HasSettingsApiBubbleBeenAcknowledged(kId3)); 720 EXPECT_FALSE(prefs->HasSettingsApiBubbleBeenAcknowledged(kId3));
721 721
722 // Clean up after ourselves. 722 // Clean up after ourselves.
723 service_->UninstallExtension( 723 service_->UninstallExtension(kId1, false, NULL);
724 kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL); 724 service_->UninstallExtension(kId2, false, NULL);
725 service_->UninstallExtension( 725 service_->UninstallExtension(kId3, false, NULL);
726 kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
727 service_->UninstallExtension(
728 kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
729 } 726 }
730 } 727 }
731 728
732 // The feature this is meant to test is only implemented on Windows. 729 // The feature this is meant to test is only implemented on Windows.
733 #if defined(OS_WIN) 730 #if defined(OS_WIN)
734 #define MAYBE_NtpOverriddenControllerTest NtpOverriddenControllerTest 731 #define MAYBE_NtpOverriddenControllerTest NtpOverriddenControllerTest
735 #else 732 #else
736 #define MAYBE_NtpOverriddenControllerTest DISABLED_NtpOverriddenControllerTest 733 #define MAYBE_NtpOverriddenControllerTest DISABLED_NtpOverriddenControllerTest
737 #endif 734 #endif
738 735
(...skipping 76 matching lines...) Expand 10 before | Expand all | Expand 10 after
815 // Only extension 2 should have become disabled. 812 // Only extension 2 should have become disabled.
816 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId1) != NULL); 813 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId1) != NULL);
817 EXPECT_TRUE(registry->disabled_extensions().GetByID(kId2) != NULL); 814 EXPECT_TRUE(registry->disabled_extensions().GetByID(kId2) != NULL);
818 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId3) != NULL); 815 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId3) != NULL);
819 // No extension should have been acknowledged (it got disabled). 816 // No extension should have been acknowledged (it got disabled).
820 EXPECT_FALSE(prefs->HasNtpOverriddenBubbleBeenAcknowledged(kId1)); 817 EXPECT_FALSE(prefs->HasNtpOverriddenBubbleBeenAcknowledged(kId1));
821 EXPECT_FALSE(prefs->HasNtpOverriddenBubbleBeenAcknowledged(kId2)); 818 EXPECT_FALSE(prefs->HasNtpOverriddenBubbleBeenAcknowledged(kId2));
822 EXPECT_FALSE(prefs->HasNtpOverriddenBubbleBeenAcknowledged(kId3)); 819 EXPECT_FALSE(prefs->HasNtpOverriddenBubbleBeenAcknowledged(kId3));
823 820
824 // Clean up after ourselves. 821 // Clean up after ourselves.
825 service_->UninstallExtension( 822 service_->UninstallExtension(kId1, false, NULL);
826 kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL); 823 service_->UninstallExtension(kId2, false, NULL);
827 service_->UninstallExtension( 824 service_->UninstallExtension(kId3, false, NULL);
828 kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
829 service_->UninstallExtension(
830 kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
831 } 825 }
832 826
833 void SetInstallTime(const std::string& extension_id, 827 void SetInstallTime(const std::string& extension_id,
834 const base::Time& time, 828 const base::Time& time,
835 ExtensionPrefs* prefs) { 829 ExtensionPrefs* prefs) {
836 std::string time_str = base::Int64ToString(time.ToInternalValue()); 830 std::string time_str = base::Int64ToString(time.ToInternalValue());
837 prefs->UpdateExtensionPref(extension_id, 831 prefs->UpdateExtensionPref(extension_id,
838 "install_time", 832 "install_time",
839 new base::StringValue(time_str)); 833 new base::StringValue(time_str));
840 } 834 }
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
938 // Only extension 2 should have become disabled. 932 // Only extension 2 should have become disabled.
939 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId1) != NULL); 933 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId1) != NULL);
940 EXPECT_TRUE(registry->disabled_extensions().GetByID(kId2) != NULL); 934 EXPECT_TRUE(registry->disabled_extensions().GetByID(kId2) != NULL);
941 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId3) != NULL); 935 EXPECT_TRUE(registry->enabled_extensions().GetByID(kId3) != NULL);
942 // No extension should have been acknowledged (it got disabled). 936 // No extension should have been acknowledged (it got disabled).
943 EXPECT_FALSE(prefs->HasProxyOverriddenBubbleBeenAcknowledged(kId1)); 937 EXPECT_FALSE(prefs->HasProxyOverriddenBubbleBeenAcknowledged(kId1));
944 EXPECT_FALSE(prefs->HasProxyOverriddenBubbleBeenAcknowledged(kId2)); 938 EXPECT_FALSE(prefs->HasProxyOverriddenBubbleBeenAcknowledged(kId2));
945 EXPECT_FALSE(prefs->HasProxyOverriddenBubbleBeenAcknowledged(kId3)); 939 EXPECT_FALSE(prefs->HasProxyOverriddenBubbleBeenAcknowledged(kId3));
946 940
947 // Clean up after ourselves. 941 // Clean up after ourselves.
948 service_->UninstallExtension( 942 service_->UninstallExtension(kId1, false, NULL);
949 kId1, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL); 943 service_->UninstallExtension(kId2, false, NULL);
950 service_->UninstallExtension( 944 service_->UninstallExtension(kId3, false, NULL);
951 kId2, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
952 service_->UninstallExtension(
953 kId3, ExtensionService::UNINSTALL_REASON_FOR_TESTING, NULL);
954 } 945 }
955 946
956 } // namespace extensions 947 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698